From: Andres Freund <andres@anarazel.de>
To: Alexander Fomichev <git.user@gmail.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Cong Wang <cwang@twopensource.com>,
Vlad Yasevich <vyasevic@redhat.com>
Subject: Re: [PATCH net] net: fix sysfs symlinks of adjacent devices
Date: Fri, 19 Sep 2014 10:59:25 +0200 [thread overview]
Message-ID: <20140919085925.GE4277@alap3.anarazel.de> (raw)
In-Reply-To: <1410516826-6926-1-git-send-email-git.user@gmail.com>
Hi,
On 2014-09-12 14:13:46 +0400, Alexander Fomichev wrote:
> From: "Alexander Y. Fomichev" <git.user@gmail.com>
>
> __netdev_adjacent_dev_insert may add adjacent device from another
> namespace. Without proper check it leads to emergence of broken
> symlink from/to device not existing in current namespace.
> Fix: check net_ns is the same before netdev_adjacent_sysfs_add/del
> related to: 4c75431ac3520631f1d9e74aa88407e6374dbbc4
>
This version, applied on top of 8ba4caf1ee, fixes the bug I had
reported. Not just the testcase, but the actual usage scenario.
I haven't tested David's version, but it doesn't look likely to be
materially different.
Greetings,
Andres Freund
prev parent reply other threads:[~2014-09-19 8:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 10:13 [PATCH net] net: fix sysfs symlinks of adjacent devices Alexander Fomichev
2014-09-12 13:33 ` Vlad Yasevich
2014-09-14 21:45 ` David Miller
2014-09-15 10:18 ` Alexander Y. Fomichev
2014-09-15 10:22 ` [PATCH net] net: fix creation adjacent device symlinks Alexander Fomichev
2014-09-15 18:25 ` David Miller
2014-09-19 8:59 ` Andres Freund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919085925.GE4277@alap3.anarazel.de \
--to=andres@anarazel.de \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=git.user@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).