Re: [PATCH/RFC repost 3/8] odp-util: formatting of datapath select group action

[Thomas Graf <tgraf-G/eBtMaohhA@public.gmane.org>]

On 09/18/14 at 10:55am, Simon Horman wrote:
> Allow formatting of select group action. This is used
> when pretty-printing datapath flows. Subsequent patches
> will add support for the select group action to the datapath
> and ovs-vswtichd.
> 
> Signed-off-by: Simon Horman <simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
> ---
>  lib/odp-util.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 67 insertions(+)
> 
> diff --git a/lib/odp-util.c b/lib/odp-util.c
> index 77b456f..4c8dd39 100644
> --- a/lib/odp-util.c
> +++ b/lib/odp-util.c
> @@ -182,6 +182,71 @@ format_odp_sample_action(struct ds *ds, const struct nlattr *attr)
>      ds_put_format(ds, "))");
>  }
>  
> +static bool
> +format_odp_bucket(struct ds *ds, const struct nlattr *attr)
> +{
> +    static const struct nl_policy ovs_sample_policy[] = {

Not that it would matter much but you might want to rename that to
ovs_bucket_policy[]. Same below.