From: Thomas Graf <tgraf-G/eBtMaohhA@public.gmane.org>
To: Simon Horman <simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
Cc: dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH/RFC repost 5/8] datapath: Move last_action() helper to datapath.h
Date: Fri, 19 Sep 2014 15:06:38 +0100 [thread overview]
Message-ID: <20140919140638.GC8257@casper.infradead.org> (raw)
In-Reply-To: <1411005311-11752-6-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
On 09/18/14 at 10:55am, Simon Horman wrote:
> diff --git a/datapath/datapath.h b/datapath/datapath.h
> index c5d3c86..74a15e6 100644
> --- a/datapath/datapath.h
> +++ b/datapath/datapath.h
> @@ -209,4 +209,9 @@ do { \
> if (net_ratelimit()) \
> pr_info("netlink: " fmt, ##__VA_ARGS__); \
> } while (0)
> +
> +static inline bool last_action(const struct nlattr *a, int rem)
> +{
> + return a->nla_len == rem;
> +}
> #endif /* datapath.h */
Can we rename & move this to <net/netlink.h> instead?
next prev parent reply other threads:[~2014-09-19 14:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 1:55 [PATCH/RFC repost 0/8] Open vSwtich ODP Select Group Action Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 1/8] odp: select group action attributes Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 2/8] netlink: Allow suppression of warnings for duplicate attributes Simon Horman
[not found] ` <1411005311-11752-3-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2014-09-26 23:55 ` Ben Pfaff
2014-10-09 1:18 ` [ovs-dev] " Simon Horman
2014-10-10 15:31 ` Ben Pfaff
2014-09-18 1:55 ` [PATCH/RFC repost 3/8] odp-util: formatting of datapath select group action Simon Horman
[not found] ` <1411005311-11752-4-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2014-09-19 13:44 ` Thomas Graf
2014-09-24 4:55 ` Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 4/8] datapath: execution of " Simon Horman
[not found] ` <1411005311-11752-5-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2014-09-19 14:05 ` Thomas Graf
2014-09-24 6:01 ` Simon Horman
2014-09-24 8:19 ` Thomas Graf
2014-09-25 4:43 ` Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 5/8] datapath: Move last_action() helper to datapath.h Simon Horman
[not found] ` <1411005311-11752-6-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2014-09-19 14:06 ` Thomas Graf [this message]
2014-09-24 6:00 ` Simon Horman
[not found] ` <20140924060013.GB13314-IxS8c3vjKQDk1uMJSBkQmQ@public.gmane.org>
2014-09-24 8:20 ` Thomas Graf
2014-09-25 4:42 ` Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 6/8] datapath: validation of select group action Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 7/8] ofproto: translate datapath " Simon Horman
[not found] ` <1411005311-11752-8-git-send-email-simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org>
2014-09-26 23:57 ` Ben Pfaff
2014-10-09 1:14 ` [ovs-dev] " Simon Horman
2014-10-13 20:46 ` Ben Pfaff
2014-10-14 4:54 ` Simon Horman
2014-09-18 1:55 ` [PATCH/RFC repost 8/8] hack: ofproto: enable odp select action Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919140638.GC8257@casper.infradead.org \
--to=tgraf-g/ebtmaohha@public.gmane.org \
--cc=dev-yBygre7rU0TnMu66kgdUjQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=simon.horman-wFxRvT7yatFl57MIdRCFDg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).