From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Tom Herbert <therbert@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Hannes Frederic Sowa <hannes@stressinduktion.org>,
Florian Westphal <fw@strlen.de>,
Daniel Borkmann <dborkman@redhat.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Alexander Duyck <alexander.duyck@gmail.com>,
John Fastabend <john.r.fastabend@intel.com>,
Dave Taht <dave.taht@gmail.com>,
toke@toke.dk
Subject: [RFC net-next PATCH V3 0/2] qdisc bulk dequeuing and utilizing delayed tailptr updates
Date: Fri, 19 Sep 2014 22:49:08 +0200 [thread overview]
Message-ID: <20140919204706.3231.59125.stgit@dragon> (raw)
This patchset uses DaveM's recent API changes to dev_hard_start_xmit(),
from the qdisc layer, to implement dequeue bulking.
RFC V3: Keeping the ball rolling.
This patchset should now use BQL correctly. I've done lots of testing
for Head-of-Line blocking issues that can occur due to requeue of a
SKB bulk list. I've not been able to provoke any HoL blocking
situation, simply because BQL is doing such a good job, thus I'm
unable to "overshoot" HW/BQL limits with more than a single packet.
This patch chooses a very conservative approach, as by default only
allowing dequeue of one extra packet, besides the normal dequeue.
Open questions:
- How do we expose tuning to userspace?
Patch adds /proc/sys/net/core/qdisc_bulk_dequeue_limit but I don't like it...
Per device tunable?
- Can/should we limit dequeue bulking to devices supporting BQL?
Based on top of net-next:
commit cb93471acc (tcp: do not fake tcp headers in tcp_send_rcvq())
---
Jesper Dangaard Brouer (1):
qdisc: bulk dequeue support for qdiscs with TCQ_F_ONETXQUEUE
Tom Herbert (1):
net: Functions to report space available in device TX queues
include/linux/netdevice.h | 28 ++++++++++++++++--
include/net/sch_generic.h | 2 +
net/core/sysctl_net_core.c | 9 ++++++
net/sched/sch_generic.c | 70 ++++++++++++++++++++++++++++++++++++++++++--
4 files changed, 104 insertions(+), 5 deletions(-)
--
next reply other threads:[~2014-09-19 20:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 20:49 Jesper Dangaard Brouer [this message]
2014-09-19 20:49 ` [RFC net-next PATCH V3 1/2] net: Functions to report space available in device TX queues Jesper Dangaard Brouer
2014-09-19 20:49 ` [RFC net-next PATCH V3 2/2] qdisc: bulk dequeue support for qdiscs with TCQ_F_ONETXQUEUE Jesper Dangaard Brouer
2014-09-20 0:22 ` Tom Herbert
2014-09-19 20:59 ` [RFC net-next PATCH V3 0/2] qdisc bulk dequeuing and utilizing delayed tailptr updates Eric Dumazet
2014-09-19 21:28 ` Dave Taht
2014-09-19 21:31 ` Jesper Dangaard Brouer
2014-09-19 21:45 ` Eric Dumazet
2014-09-19 22:39 ` Cong Wang
2014-09-19 22:52 ` Eric Dumazet
2014-09-20 0:31 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140919204706.3231.59125.stgit@dragon \
--to=brouer@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=hannes@stressinduktion.org \
--cc=jhs@mojatatu.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).