From: Thomas Graf <tgraf@suug.ch>
To: Jiri Pirko <jiri@resnulli.us>
Cc: John Fastabend <john.r.fastabend@intel.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
netdev@vger.kernel.org, davem@davemloft.net,
nhorman@tuxdriver.com, andy@greyhouse.net, dborkman@redhat.com,
ogerlitz@mellanox.com, jesse@nicira.com, pshelar@nicira.com,
azhou@nicira.com, ben@decadent.org.uk,
stephen@networkplumber.org, jeffrey.t.kirsher@intel.com,
vyasevic@redhat.com, xiyou.wangcong@gmail.com,
edumazet@google.com, sfeldma@cumulusnetworks.com,
f.fainelli@gmail.com, roopa@cumulusnetworks.com,
linville@tuxdriver.com, dev@openvswitch.org, jasowang@redhat.com,
ebiederm@xmission.com, nicolas.dichtel@6wind.com,
ryazanov.s.a@gmail.com, buytenh@wantstofly.org,
aviadr@mellanox.com, nbd@openwrt.org,
alexei.starovoitov@gmail.com, Neil.Jerram@metaswitch.com,
ronye@mellanox.com, simon.horman@netronome.com,
alexander.h.duyck@intel.com
Subject: Re: [patch net-next v2 8/9] switchdev: introduce Netlink API
Date: Sat, 20 Sep 2014 11:53:54 +0100 [thread overview]
Message-ID: <20140920105354.GA29419@casper.infradead.org> (raw)
In-Reply-To: <20140920081426.GE1821@nanopsycho.orion>
On 09/20/14 at 10:14am, Jiri Pirko wrote:
> Sat, Sep 20, 2014 at 12:12:12AM CEST, john.r.fastabend@intel.com wrote:
> >I was considering a slightly different approach where the
> >device would report via netlink the fields/actions it
> >supported rather than creating pre-defined enums for every
> >possible key.
> >
> >I already need to have an API to report fields/matches
> >that are being supported why not have the device report
> >the headers as header fields (len, offset) and the
> >associated parse graph the hardware uses? Vendors should
> >have this already to describe/design their real hardware.
>
> Hmm, let me think about this a bit more. I will try to figure out how to
> handle that. Sound logic though. Will try to incorporate the idea in the
> patchset.
I think this is the right track.
I agree with Jamal that there is no need for a new permanent and
separate Netlink interface for this. I think this would best be described
as a structure of nested Netlink attributes in the form John proposes
which is then embedded into existing Netlink interfaces such as rtnetlink
and OVS genl.
OVS can register new genl ops to check capabilities and insert
hardware flows which allows implementation of the offload decision in
user space and allows for arbitary combination of hardware and software
flows. It also allows to run a eBPF software data path in combination
with a hardware flow setup.
rtnetlink can embed the nested attribute structure into existing APIs
to allow feature capability detection from user space, statistic
reporting and optional direct hardware offload if a transaprent
offload is not feasible. Would that work for you John?
I think we should focus on getting the layering right and make it
generic enough so we allow evolving naturally.
next prev parent reply other threads:[~2014-09-20 10:54 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 13:49 [patch net-next v2 0/9] introduce rocker switch driver with hardware accelerated datapath api Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 1/9] net: rename netdev_phys_port_id to more generic name Jiri Pirko
[not found] ` <1411134590-4586-2-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2014-09-19 13:54 ` Jeff Kirsher
2014-09-19 13:49 ` [patch net-next v2 3/9] rtnl: expose physical switch id for particular device Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 4/9] net-sysfs: " Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 5/9] net: introduce dummy switch Jiri Pirko
[not found] ` <1411134590-4586-6-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2014-09-20 5:21 ` Florian Fainelli
2014-09-20 7:37 ` Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 6/9] switchdev: add basic support for flow matching and actions Jiri Pirko
2014-09-20 5:32 ` Florian Fainelli
2014-09-20 7:28 ` Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 7/9] switchdev: add swdev features Jiri Pirko
2014-09-19 13:49 ` [patch net-next v2 8/9] switchdev: introduce Netlink API Jiri Pirko
2014-09-19 15:25 ` Jamal Hadi Salim
2014-09-19 15:49 ` Jiri Pirko
2014-09-19 17:57 ` Jamal Hadi Salim
2014-09-19 22:12 ` John Fastabend
2014-09-19 22:18 ` Jamal Hadi Salim
2014-09-20 5:39 ` Florian Fainelli
2014-09-20 8:25 ` Jiri Pirko
2014-09-20 8:17 ` Jiri Pirko
2014-09-20 10:19 ` Jamal Hadi Salim
2014-09-20 11:01 ` Thomas Graf
2014-09-20 11:32 ` Jamal Hadi Salim
2014-09-20 11:51 ` Thomas Graf
[not found] ` <20140920115140.GA3777-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2014-09-20 12:35 ` Jamal Hadi Salim
2014-09-22 7:53 ` Jiri Pirko
[not found] ` <20140922075337.GA1828-6KJVSR23iU488b5SBfVpbw@public.gmane.org>
2014-09-22 11:48 ` Jamal Hadi Salim
2014-09-20 5:36 ` Florian Fainelli
2014-09-20 8:14 ` Jiri Pirko
2014-09-20 10:53 ` Thomas Graf [this message]
2014-09-20 22:50 ` Alexei Starovoitov
2014-09-22 8:13 ` Thomas Graf
2014-09-22 15:10 ` Tom Herbert
2014-09-22 22:17 ` Thomas Graf
[not found] ` <20140922221727.GA4708-FZi0V3Vbi30CUdFEqe4BF2D2FQJk+8+b@public.gmane.org>
2014-09-22 22:40 ` Tom Herbert
2014-09-22 22:53 ` Thomas Graf
2014-09-22 23:07 ` Tom Herbert
2014-09-23 1:36 ` John Fastabend
2014-09-23 7:19 ` Thomas Graf
2014-09-23 11:09 ` Jamal Hadi Salim
[not found] ` <CA+mtBx9ZVQ5r5Hzy9-uEnk+iu+HKkOP4+VANC06Xf8VvTxktwQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-23 9:18 ` Thomas Graf
2014-09-23 1:54 ` Alexei Starovoitov
2014-09-23 2:16 ` Tom Herbert
2014-09-23 4:11 ` Andy Gospodarek
2014-09-23 10:11 ` Thomas Graf
2014-09-23 15:32 ` Or Gerlitz
2014-09-24 13:32 ` Thomas Graf
2014-09-26 20:03 ` Or Gerlitz
2014-09-26 21:02 ` Thomas Graf
2014-09-23 9:52 ` Thomas Graf
2014-09-20 3:41 ` Roopa Prabhu
2014-09-20 8:09 ` Jiri Pirko
2014-09-20 12:39 ` Roopa Prabhu
2014-09-20 8:10 ` Scott Feldman
2014-09-20 10:31 ` Jamal Hadi Salim
[not found] ` <DDC24110-C3F5-470F-B9BE-1D1792415D1E-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>
2014-09-20 12:51 ` Roopa Prabhu
2014-09-20 17:21 ` Scott Feldman
2014-09-20 17:38 ` Jiri Pirko
2014-09-21 1:30 ` Roopa Prabhu
2014-09-19 13:49 ` [patch net-next v2 9/9] rocker: introduce rocker switch driver Jiri Pirko
[not found] ` <1411134590-4586-1-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2014-09-19 13:49 ` [patch net-next v2 2/9] net: introduce generic switch devices support Jiri Pirko
2014-09-19 14:15 ` [patch net-next v2 0/9] introduce rocker switch driver with hardware accelerated datapath api David Laight
[not found] ` <063D6719AE5E284EB5DD2968C1650D6D17495CC6-VkEWCZq2GCInGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2014-09-19 14:20 ` Jiri Pirko
2014-09-20 5:37 ` Florian Fainelli
-- strict thread matches above, loose matches on Subject: below --
2014-09-23 3:43 [patch net-next v2 8/9] switchdev: introduce Netlink API Alexei Starovoitov
2014-09-23 20:57 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140920105354.GA29419@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=Neil.Jerram@metaswitch.com \
--cc=alexander.h.duyck@intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andy@greyhouse.net \
--cc=aviadr@mellanox.com \
--cc=azhou@nicira.com \
--cc=ben@decadent.org.uk \
--cc=buytenh@wantstofly.org \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=dev@openvswitch.org \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jasowang@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse@nicira.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.r.fastabend@intel.com \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=nicolas.dichtel@6wind.com \
--cc=ogerlitz@mellanox.com \
--cc=pshelar@nicira.com \
--cc=ronye@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=ryazanov.s.a@gmail.com \
--cc=sfeldma@cumulusnetworks.com \
--cc=simon.horman@netronome.com \
--cc=stephen@networkplumber.org \
--cc=vyasevic@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).