From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@6wind.com
Cc: netdev@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH net] macvlan: allow to enqueue broadcast pkt on virtual device
Date: Mon, 22 Sep 2014 14:10:48 -0400 (EDT) [thread overview]
Message-ID: <20140922.141048.2225879376615599480.davem@davemloft.net> (raw)
In-Reply-To: <1410941288-1880-1-git-send-email-nicolas.dichtel@6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Wed, 17 Sep 2014 10:08:08 +0200
> Since commit 412ca1550cbe ("macvlan: Move broadcasts into a work queue"), the
> driver uses tx_queue_len of the master device as the limit of packets enqueuing.
> Problem is that virtual drivers have this value set to 0, thus all broadcast
> packets were rejected.
> Because tx_queue_len was arbitrarily chosen, I replace it with a static limit
> of 1000 (also arbitrarily chosen).
>
> CC: Herbert Xu <herbert@gondor.apana.org.au>
> Reported-by: Thibaut Collet <thibaut.collet@6wind.com>
> Suggested-by: Thibaut Collet <thibaut.collet@6wind.com>
> Tested-by: Thibaut Collet <thibaut.collet@6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Applied and queued up for -stable.
Longer term we should come up with something a little bit nicer.
prev parent reply other threads:[~2014-09-22 18:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 8:08 [PATCH net] macvlan: allow to enqueue broadcast pkt on virtual device Nicolas Dichtel
2014-09-19 20:03 ` David Miller
2014-09-19 23:31 ` Herbert Xu
2014-09-19 23:44 ` Eric Dumazet
2014-09-19 21:24 ` Cong Wang
2014-09-19 21:35 ` Eric Dumazet
2014-09-19 21:59 ` Cong Wang
2014-09-19 22:05 ` Eric Dumazet
2014-09-19 22:14 ` Cong Wang
2014-09-19 22:44 ` Eric Dumazet
2014-09-19 22:57 ` Cong Wang
2014-09-19 23:09 ` Eric Dumazet
2014-09-20 2:00 ` David Miller
2014-09-22 18:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922.141048.2225879376615599480.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).