* [patch -next] r8169: fix an if condition
@ 2014-09-19 10:40 Dan Carpenter
2014-09-22 2:30 ` Hayes Wang
2014-09-22 19:19 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-09-19 10:40 UTC (permalink / raw)
To: Realtek linux nic maintainers, hayeswang; +Cc: netdev, kernel-janitors
There is an extra semi-colon so __rtl8169_set_features() is called every
time.
Fixes: 929a031dfd62 ('r8169: adjust __rtl8169_set_features')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 3027f4a..1d81238 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -1882,7 +1882,7 @@ static int rtl8169_set_features(struct net_device *dev,
features &= NETIF_F_RXALL | NETIF_F_RXCSUM | NETIF_F_HW_VLAN_CTAG_RX;
rtl_lock_work(tp);
- if (features ^ dev->features);
+ if (features ^ dev->features)
__rtl8169_set_features(dev, features);
rtl_unlock_work(tp);
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [patch -next] r8169: fix an if condition
2014-09-19 10:40 [patch -next] r8169: fix an if condition Dan Carpenter
@ 2014-09-22 2:30 ` Hayes Wang
2014-09-22 19:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Hayes Wang @ 2014-09-22 2:30 UTC (permalink / raw)
To: Dan Carpenter, nic_swsd
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Friday, September 19, 2014 6:40 PM
[...]
> There is an extra semi-colon so __rtl8169_set_features() is
> called every
> time.
Acked-by: Hayes Wang <hayeswang@realtek.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch -next] r8169: fix an if condition
2014-09-19 10:40 [patch -next] r8169: fix an if condition Dan Carpenter
2014-09-22 2:30 ` Hayes Wang
@ 2014-09-22 19:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-09-22 19:19 UTC (permalink / raw)
To: dan.carpenter; +Cc: nic_swsd, hayeswang, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 19 Sep 2014 13:40:25 +0300
> There is an extra semi-colon so __rtl8169_set_features() is called every
> time.
>
> Fixes: 929a031dfd62 ('r8169: adjust __rtl8169_set_features')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Dan, this bug exists in 'net' so that is what you should have
targetted this tree at.
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-22 19:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-19 10:40 [patch -next] r8169: fix an if condition Dan Carpenter
2014-09-22 2:30 ` Hayes Wang
2014-09-22 19:19 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).