From: David Miller <davem@davemloft.net>
To: tklauser@distanz.ch
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] dm9000: Return an ERR_PTR() in all error conditions of dm9000_parse_dt()
Date: Mon, 22 Sep 2014 16:03:13 -0400 (EDT) [thread overview]
Message-ID: <20140922.160313.17177368094902322.davem@davemloft.net> (raw)
In-Reply-To: <1411136185-28658-1-git-send-email-tklauser@distanz.ch>
From: Tobias Klauser <tklauser@distanz.ch>
Date: Fri, 19 Sep 2014 16:16:25 +0200
> In one error condition dm9000_parse_dt() returns NULL, however the
> return value is checked using IS_ERR() in dm9000_probe(), leading to the
> error not being properly propagated if CONFIG_OF is not enabled or the
> device tree data is not available. Fix this by also returning an
> ERR_PTR() in this case.
>
> Fixes: 0b8bf1baabe5 (net: dm9000: Allow instantiation using device tree)
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied, thanks.
prev parent reply other threads:[~2014-09-22 20:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 14:16 [PATCH net] dm9000: Return an ERR_PTR() in all error conditions of dm9000_parse_dt() Tobias Klauser
2014-09-22 20:03 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922.160313.17177368094902322.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).