From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: ycheng@google.com, joe@perches.com, netdev@vger.kernel.org,
ncardwell@google.com
Subject: Re: [PATCH v3 net-next] tcp: avoid possible arithmetic overflows
Date: Mon, 22 Sep 2014 16:27:03 -0400 (EDT) [thread overview]
Message-ID: <20140922.162703.824025819934075774.davem@davemloft.net> (raw)
In-Reply-To: <1411417184.26859.147.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 22 Sep 2014 13:19:44 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> icsk_rto is a 32bit field, and icsk_backoff can reach 15 by default,
> or more if some sysctl (eg tcp_retries2) are changed.
>
> Better use 64bit to perform icsk_rto << icsk_backoff operations
>
> As Joe Perches suggested, add a helper for this.
>
> Yuchung spotted the tcp_v4_err() case.
>
> From: Eric Dumazet <edumazet@google.com>
I assume you meant "Signed-off-by: " on that last line, not "From: " :-)
Applied,
next prev parent reply other threads:[~2014-09-22 20:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 17:19 [PATCH net-next] tcp: avoid possible arithmetic overflows Eric Dumazet
2014-09-20 18:01 ` Joe Perches
2014-09-20 19:46 ` Yuchung Cheng
2014-09-20 19:55 ` Eric Dumazet
2014-09-20 20:19 ` Joe Perches
2014-09-21 0:29 ` [PATCH v2 " Eric Dumazet
2014-09-21 17:46 ` Yuchung Cheng
2014-09-22 12:42 ` Eric Dumazet
2014-09-22 20:19 ` [PATCH v3 " Eric Dumazet
2014-09-22 20:27 ` David Miller [this message]
2014-09-22 20:28 ` Eric Dumazet
2014-09-22 3:56 ` [PATCH v2 " Joe Perches
2014-09-22 11:13 ` [PATCH " David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140922.162703.824025819934075774.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=joe@perches.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).