netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chuck Ebbert <cebbert.lkml@gmail.com>
To: Willem de Bruijn <willemb@google.com>
Cc: Network Development <netdev@vger.kernel.org>
Subject: Re: LTP recv/recvmsg tests failing on 3.17
Date: Tue, 23 Sep 2014 10:39:33 -0500	[thread overview]
Message-ID: <20140923103933.1b5fb88b@as> (raw)
In-Reply-To: <CA+FuTScNSGYxWtB-D_iL_7TQO=z4r5_29-W8d=VRwh1M6Ym_UQ@mail.gmail.com>

On Tue, 23 Sep 2014 10:57:41 -0400
Willem de Bruijn <willemb@google.com> wrote:

> I think applications simply cannot assume a consistent
> return value when passing unsupported combinations
> of flags. This is undefined behavior.

Yeah, I think LTP is wrong here. There is no explicit test for invalid
combinations of flags and it was assuming there was.

But I was also wondering why we return EAGAIN here for no data waiting,
when we return EINVAL for the same case with a different type of data.
There's no spec and it's not documented, so I guess the answer is "it's
always been that way."

  reply	other threads:[~2014-09-23 15:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23 14:11 LTP recv/recvmsg tests failing on 3.17 Chuck Ebbert
2014-09-23 14:57 ` Willem de Bruijn
2014-09-23 15:39   ` Chuck Ebbert [this message]
2014-09-23 16:24     ` Willem de Bruijn
2014-09-23 15:59   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140923103933.1b5fb88b@as \
    --to=cebbert.lkml@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).