From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antoine Tenart Subject: Re: [PATCH v4 3/9] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller Date: Tue, 23 Sep 2014 16:01:13 +0200 Message-ID: <20140923140113.GC18924@kwain> References: <1411474536-22626-1-git-send-email-antoine.tenart@free-electrons.com> <1411474536-22626-4-git-send-email-antoine.tenart@free-electrons.com> <51745791.Wuu5QiQB2e@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Antoine Tenart , sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, zmxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org, jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Return-path: Content-Disposition: inline In-Reply-To: <51745791.Wuu5QiQB2e@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Arnd, On Tue, Sep 23, 2014 at 02:38:39PM +0200, Arnd Bergmann wrote: > On Tuesday 23 September 2014 14:15:30 Antoine Tenart wrote: > > +Optional properties: > > +- port-id: should be '0','1' or '2'. > > +- phy-addr: MDIO address of the PHY. > > +- local-mac-address: see ethernet.txt file in the same directory. > > + > >=20 >=20 > I believe new bindings should not use "phy-addr" properties, but > instead use a phy-handle property pointing to a phy device instead. That's the MDIO address of the PHY. It's a bit difficult to use a phy device as the driver uses the libphy. And that would break the platform using it. Or maybe you have something in mind? >=20 > The port-id property description could be a little more verbose. > What do those numbers actually mean? I'll add some description. That's the Ethernet port number. I reused a property (port-id) already used by other drivers. Antoine --=20 Antoine T=E9nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html