From: "John W. Linville" <linville@tuxdriver.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Joe Perches <joe@perches.com>,
Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
wil6210 <wil6210@qca.qualcomm.com>,
ath6kl@lists.infradead.org
Subject: Re: [PATCH] ath: change logging functions to return void
Date: Tue, 23 Sep 2014 10:46:27 -0400 [thread overview]
Message-ID: <20140923144627.GG23806@tuxdriver.com> (raw)
In-Reply-To: <874mvzj7bu.fsf@kamboji.qca.qualcomm.com>
On Tue, Sep 23, 2014 at 07:20:53AM +0300, Kalle Valo wrote:
> Joe Perches <joe@perches.com> writes:
>
> > The return values are not used by callers of these functions
> > so change the functions to return void.
> >
> > Other miscellanea:
> >
> > o add __printf verification to wil6210 logging functions
> > No format/argument mismatches found
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> > This change is associated to a desire to eventually
> > change printk to return void.
> >
> > drivers/net/wireless/ath/ath10k/debug.c | 18 +++++-------------
> > drivers/net/wireless/ath/ath10k/debug.h | 6 +++---
> > drivers/net/wireless/ath/ath6kl/common.h | 2 +-
> > drivers/net/wireless/ath/ath6kl/debug.c | 28 ++++++++--------------------
> > drivers/net/wireless/ath/ath6kl/debug.h | 13 ++++++-------
>
> For ath6kl and ath10k:
>
> Acked-by: Kalle Valo <kvalo@qca.qualcomm.com>
>
> > drivers/net/wireless/ath/wil6210/debug.c | 14 ++++----------
> > drivers/net/wireless/ath/wil6210/wil6210.h | 7 +++++--
> > 7 files changed, 32 insertions(+), 56 deletions(-)
>
> John, as this patch also contains a wil6210 change how do you want to
> handle this?
I had presumed that you would merge it through the ath tree, so I
deleted it...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2014-09-23 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 17:35 [PATCH] ath: change logging functions to return void Joe Perches
2014-09-23 4:20 ` Kalle Valo
2014-09-23 14:46 ` John W. Linville [this message]
2014-09-23 15:17 ` Kalle Valo
2014-09-23 14:05 ` Vladimir Kondratiev
2014-09-29 11:28 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140923144627.GG23806@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath10k@lists.infradead.org \
--cc=ath6kl@lists.infradead.org \
--cc=joe@perches.com \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qca_vkondrat@qca.qualcomm.com \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).