From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
hideaki@yoshifuji.org, vyasevich@gmail.com,
nicolas.dichtel@6wind.com, kafai@fb.com
Subject: Re: [PATCH v2 net-next 0/9] ipv6: fib6: socket dst_entry improvments and cleanups
Date: Fri, 26 Sep 2014 00:28:53 -0400 (EDT) [thread overview]
Message-ID: <20140926.002853.1097612772155886372.davem@davemloft.net> (raw)
In-Reply-To: <cover.1411308211.git.hannes@stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Sun, 21 Sep 2014 16:11:44 +0200
> Eric Dumazet noticed that rt6_nodes wich are neither RTF_NONEXTHOP nor
> RTF_GATEWAY but DST_HOST ones cause major routing lookup churn because
> their rt6_genid is never renewed, thus ip6_dst_check always considers
> them outdated. This is a major problem, because these kind of routes
> are normally used to in input handling.
This series is a disappointment for me from the perspective of the
fact that we have a regression in mainline and this is too complex
of a set of changes for there.
If we relookup the thing every TCP input packet, we might as well
not do the input route caching in the socket.
next prev parent reply other threads:[~2014-09-26 4:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 14:11 [PATCH v2 net-next 0/9] ipv6: fib6: socket dst_entry improvments and cleanups Hannes Frederic Sowa
2014-09-21 14:11 ` [PATCH v2 net-next 1/9] ipv6: support for fib6_clean_* to update fn_sernum Hannes Frederic Sowa
2014-09-21 14:11 ` [PATCH v2 net-next 2/9] ipv6: a bit more typesafety Hannes Frederic Sowa
2014-09-21 14:11 ` [PATCH v2 net-next 3/9] ipv6: only generate one new serial number during fib6_add() Hannes Frederic Sowa
2014-09-21 14:11 ` [PATCH v2 net-next 4/9] ipv6: if no function for cleaner is specified only visit fib6_nodes Hannes Frederic Sowa
2014-09-21 14:11 ` [PATCH v2 net-next 5/9] ipv6: new function fib6_flush_trees and use it instead of bumping removed rt6_genid Hannes Frederic Sowa
2014-09-21 14:11 ` [PATCH v2 net-next 6/9] ipv6: no need to bump rt_genid_ipv6 on address addition Hannes Frederic Sowa
2014-09-21 14:11 ` [PATCH v2 net-next 7/9] ipv6: keep rt_sernum per namespace to reduce number of flushes Hannes Frederic Sowa
2014-09-21 14:11 ` [PATCH v2 net-next 8/9] ipv6: switch rt_sernum to atomic_t and clean up types Hannes Frederic Sowa
2014-09-21 14:11 ` [PATCH v2 net-next 9/9] ipv6: rename rt_genid_bump_ipv6 to rt6_inval_dst_caches Hannes Frederic Sowa
2014-09-26 4:28 ` David Miller [this message]
2014-09-26 7:58 ` [PATCH v2 net-next 0/9] ipv6: fib6: socket dst_entry improvments and cleanups Hannes Frederic Sowa
2014-09-26 16:46 ` David Miller
2014-09-27 23:32 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926.002853.1097612772155886372.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=hideaki@yoshifuji.org \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox