From: David Miller <davem@davemloft.net>
To: festevam@gmail.com
Cc: Frank.Li@freescale.com, netdev@vger.kernel.org,
fabio.estevam@freescale.com
Subject: Re: [PATCH net-next v3] fec: Remove fec_enet_select_queue()
Date: Fri, 26 Sep 2014 15:22:14 -0400 (EDT) [thread overview]
Message-ID: <20140926.152214.2057397298920833937.davem@davemloft.net> (raw)
In-Reply-To: <1411419329-11957-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <festevam@gmail.com>
Date: Mon, 22 Sep 2014 17:55:29 -0300
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Sparse complains about fec_enet_select_queue() not being static.
>
> Feedback from David Miller [1] was to remove this function instead of making it
> static:
>
> "Please just delete this function.
>
> It's overriding code which does exactly the same thing.
>
> Actually, more precisely, this code is duplicating code in a way that
> bypasses many core facilitites of the networking. For example, this
> override means that socket based flow steering, XPS, etc. are all
> not happening on these devices.
>
> Without ->ndo_select_queue(), the flow dissector does __netdev_pick_tx
> which is exactly what you want to happen."
>
> [1] http://www.spinics.net/lists/netdev/msg297653.html
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Looks a lot better, applied, thanks!
prev parent reply other threads:[~2014-09-26 19:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 20:55 [PATCH net-next v3] fec: Remove fec_enet_select_queue() Fabio Estevam
2014-09-26 19:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926.152214.2057397298920833937.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Frank.Li@freescale.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).