From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: introduce __skb_header_release()
Date: Fri, 26 Sep 2014 15:40:21 -0400 (EDT) [thread overview]
Message-ID: <20140926.154021.663234155981881132.davem@davemloft.net> (raw)
In-Reply-To: <1411428572.26859.165.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 22 Sep 2014 16:29:32 -0700
> From: Eric Dumazet <edumazet@google.com>
>
> While profiling TCP stack, I noticed one useless atomic operation
> in tcp_sendmsg(), caused by skb_header_release().
>
> It turns out all current skb_header_release() users have a fresh skb,
> that no other user can see, so we can avoid one atomic operation.
>
> Introduce __skb_header_release() to clearly document this.
>
> This gave me a 1.5 % improvement on TCP_RR workload.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Looks great, applied, thanks!
prev parent reply other threads:[~2014-09-26 19:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 23:29 [PATCH net-next] net: introduce __skb_header_release() Eric Dumazet
2014-09-26 19:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926.154021.663234155981881132.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox