netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ycheng@google.com
Cc: edumazet@google.com, andrey.dmitrov@oktetlabs.ru,
	ncardwell@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] tcp: abort orphan sockets stalling on zero window probes
Date: Fri, 26 Sep 2014 15:56:11 -0400 (EDT)	[thread overview]
Message-ID: <20140926.155611.954320324745536887.davem@davemloft.net> (raw)
In-Reply-To: <1411444333-6013-1-git-send-email-ycheng@google.com>

From: Yuchung Cheng <ycheng@google.com>
Date: Mon, 22 Sep 2014 20:52:13 -0700

> -
> +		if (!alive && icsk->icsk_backoff >= max_probes)
> +			goto abort;
>  		if (tcp_out_of_resources(sk, alive || icsk->icsk_probes_out <= max_probes))
>  			return;

This new logic means that the second argument to tcp_out_of_resources()
will always be 'true'.

Please make that explicit, because the code is confusing otherwise.

Also perhaps target this for the 'net' tree?

Thanks.

  reply	other threads:[~2014-09-26 19:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23  3:52 [PATCH net-next] tcp: abort orphan sockets stalling on zero window probes Yuchung Cheng
2014-09-26 19:56 ` David Miller [this message]
2014-09-29 19:17   ` Yuchung Cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140926.155611.954320324745536887.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andrey.dmitrov@oktetlabs.ru \
    --cc=edumazet@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).