Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: b38611@freescale.com
Cc: b20596@freescale.com, netdev@vger.kernel.org,
	shawn.guo@linaro.org, bhutchings@solarflare.com
Subject: Re: [PATCH] net: fec: remove memory copy for rx path
Date: Fri, 26 Sep 2014 17:07:20 -0400 (EDT)	[thread overview]
Message-ID: <20140926.170720.2230061639326332503.davem@davemloft.net> (raw)
In-Reply-To: <1411538730-31480-1-git-send-email-b38611@freescale.com>

From: Fugang Duan <b38611@freescale.com>
Date: Wed, 24 Sep 2014 14:05:30 +0800

> Re-allocate skb instead of memory copy skb data in rx path to improve
> enet rx performance.
> 
> Signed-off-by: Fugang Duan <B38611@freescale.com>
> Signed-off-by: Frank Li <Frank.Li@freescale.com>

For small packet sizes, copying is almost certainly faster and it avoids
mismatched skb->truesize vs. skb->len which hurts TCP performance.

We call this rx_copybreak, and there are many drivers you can look at
to see how this works.

Thanks.

  reply	other threads:[~2014-09-26 21:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24  6:05 [PATCH] net: fec: remove memory copy for rx path Fugang Duan
2014-09-26 21:07 ` David Miller [this message]
2014-09-27  9:15   ` fugang.duan
2014-09-27 11:39     ` Francois Romieu
2014-09-27 22:56       ` David Miller
2014-09-28  3:30         ` fugang.duan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140926.170720.2230061639326332503.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=b20596@freescale.com \
    --cc=b38611@freescale.com \
    --cc=bhutchings@solarflare.com \
    --cc=netdev@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox