From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, ycheng@google.com, ncardwell@google.com,
christoph.paasch@uclouvain.be
Subject: Re: [PATCH v4 net-next 0/3] tcp: better TCP_SKB_CB layout
Date: Sun, 28 Sep 2014 16:36:11 -0400 (EDT) [thread overview]
Message-ID: <20140928.163611.307968379739374310.davem@davemloft.net> (raw)
In-Reply-To: <1411836657-9542-1-git-send-email-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Sat, 27 Sep 2014 09:50:54 -0700
> TCP had the assumption that IPCB and IP6CB are first members of skb->cb[]
>
> This is fine, except that IPCB/IP6CB are used in TCP for a very short time
> in input path.
>
> What really matters for TCP stack is to get skb->next,
> TCP_SKB_CB(skb)->seq, and TCP_SKB_CB(skb)->end_seq in the same cache line.
>
> skb that are immediately consumed do not care because whole skb->cb[] is
> hot in cpu cache, while skb that sit in wocket write queue or receive queues
> do not need TCP_SKB_CB(skb)->header at all.
>
> This patch set implements the prereq for IPv4, IPv6, and TCP to make this
> possible. This makes TCP more efficient.
Series applied, thanks.
prev parent reply other threads:[~2014-09-28 20:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 16:50 [PATCH v4 net-next 0/3] tcp: better TCP_SKB_CB layout Eric Dumazet
2014-09-27 16:50 ` [PATCH v4 net-next 1/3] ipv4: rename ip_options_echo to __ip_options_echo() Eric Dumazet
2014-09-27 16:50 ` [PATCH v4 net-next 2/3] ipv6: add a struct inet6_skb_parm param to ipv6_opt_accepted() Eric Dumazet
2014-09-27 16:50 ` [PATCH v4 net-next 3/3] tcp: better TCP_SKB_CB layout to reduce cache line misses Eric Dumazet
2014-09-28 20:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140928.163611.307968379739374310.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=christoph.paasch@uclouvain.be \
--cc=edumazet@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).