* [PATCH] wireless: Remove unnessary write over of register 11 in rt2800lib.c @ 2014-09-27 21:11 Nicholas Krause 2014-09-28 7:09 ` [rt2x00-users] " Stanislaw Gruszka 0 siblings, 1 reply; 6+ messages in thread From: Nicholas Krause @ 2014-09-27 21:11 UTC (permalink / raw) To: IvDoorn-Re5JQEeQqe8AvxtiuMwx3w Cc: helmut.schaa-gM/Ye1E23mwN+BqQ9rBEUg, linville-2XuSBdqkA4R54TAoqtyWWQ, linux-wireless-u79uwXL29TY76Z2rM5mHXA, users-poMEt7QlJxcwIE2E9O76wjtx2kNaKg5H, netdev-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA This removes the unnecessary overwrite of register 11 in the function, rt2800_config_channel as we are already writing a correct value to the register with rt2800_rfcsr_write(rt2x00dev,11.rfcsr). Signed-off-by: Nicholas Krause <yocto6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> --- drivers/net/wireless/rt2x00/rt2800lib.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c index 893c9d5..fb0ae38 100644 --- a/drivers/net/wireless/rt2x00/rt2800lib.c +++ b/drivers/net/wireless/rt2x00/rt2800lib.c @@ -2787,8 +2787,6 @@ static void rt2800_config_channel_rf55xx(struct rt2x00_dev *rt2x00dev, if (rf->channel <= 14) { rt2800_rfcsr_write(rt2x00dev, 10, 0x90); - /* FIXME: RF11 owerwrite ? */ - rt2800_rfcsr_write(rt2x00dev, 11, 0x4A); rt2800_rfcsr_write(rt2x00dev, 12, 0x52); rt2800_rfcsr_write(rt2x00dev, 13, 0x42); rt2800_rfcsr_write(rt2x00dev, 22, 0x40); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [rt2x00-users] [PATCH] wireless: Remove unnessary write over of register 11 in rt2800lib.c 2014-09-27 21:11 [PATCH] wireless: Remove unnessary write over of register 11 in rt2800lib.c Nicholas Krause @ 2014-09-28 7:09 ` Stanislaw Gruszka [not found] ` <20140928070923.GA2087-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Stanislaw Gruszka @ 2014-09-28 7:09 UTC (permalink / raw) To: Nicholas Krause; +Cc: IvDoorn, netdev, linux-wireless, users, linux-kernel On Sat, Sep 27, 2014 at 05:11:41PM -0400, Nicholas Krause wrote: > This removes the unnecessary overwrite of register 11 in the function, > rt2800_config_channel as we are already writing a correct value to the > register with rt2800_rfcsr_write(rt2x00dev,11.rfcsr). What make you sure that overwrite is unnecessary ? > > Signed-off-by: Nicholas Krause <yocto6@gmail.com> > --- > drivers/net/wireless/rt2x00/rt2800lib.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c > index 893c9d5..fb0ae38 100644 > --- a/drivers/net/wireless/rt2x00/rt2800lib.c > +++ b/drivers/net/wireless/rt2x00/rt2800lib.c > @@ -2787,8 +2787,6 @@ static void rt2800_config_channel_rf55xx(struct rt2x00_dev *rt2x00dev, > > if (rf->channel <= 14) { > rt2800_rfcsr_write(rt2x00dev, 10, 0x90); > - /* FIXME: RF11 owerwrite ? */ > - rt2800_rfcsr_write(rt2x00dev, 11, 0x4A); We need a prove that remove is correct, i.e. some reference to vendor code or spec that current writing register twice with different values is wrong. NACK for the patch. Stanislaw ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20140928070923.GA2087-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]
* Re: [rt2x00-users] [PATCH] wireless: Remove unnessary write over of register 11 in rt2800lib.c [not found] ` <20140928070923.GA2087-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> @ 2014-09-28 8:05 ` Denis Kirjanov [not found] ` <CAOJe8K1nkeVjNpNoUBxuJv-YXj3Wr_oH86yR31U7w3Jq5j7oxw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 6+ messages in thread From: Denis Kirjanov @ 2014-09-28 8:05 UTC (permalink / raw) To: Stanislaw Gruszka Cc: Nicholas Krause, IvDoorn-Re5JQEeQqe8AvxtiuMwx3w, netdev-u79uwXL29TY76Z2rM5mHXA, linux-wireless-u79uwXL29TY76Z2rM5mHXA, users-poMEt7QlJxcwIE2E9O76wjtx2kNaKg5H, linux-kernel-u79uwXL29TY76Z2rM5mHXA Or someone with the hardware has to test and check that... On 9/28/14, Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote: > On Sat, Sep 27, 2014 at 05:11:41PM -0400, Nicholas Krause wrote: >> This removes the unnecessary overwrite of register 11 in the function, >> rt2800_config_channel as we are already writing a correct value to the >> register with rt2800_rfcsr_write(rt2x00dev,11.rfcsr). > What make you sure that overwrite is unnecessary ? > >> >> Signed-off-by: Nicholas Krause <yocto6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> --- >> drivers/net/wireless/rt2x00/rt2800lib.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c >> b/drivers/net/wireless/rt2x00/rt2800lib.c >> index 893c9d5..fb0ae38 100644 >> --- a/drivers/net/wireless/rt2x00/rt2800lib.c >> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c >> @@ -2787,8 +2787,6 @@ static void rt2800_config_channel_rf55xx(struct >> rt2x00_dev *rt2x00dev, >> >> if (rf->channel <= 14) { >> rt2800_rfcsr_write(rt2x00dev, 10, 0x90); >> - /* FIXME: RF11 owerwrite ? */ >> - rt2800_rfcsr_write(rt2x00dev, 11, 0x4A); > We need a prove that remove is correct, i.e. some reference to > vendor code or spec that current writing register twice with > different values is wrong. > > NACK for the patch. > > Stanislaw > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CAOJe8K1nkeVjNpNoUBxuJv-YXj3Wr_oH86yR31U7w3Jq5j7oxw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] wireless: Remove unnessary write over of register 11 in rt2800lib.c [not found] ` <CAOJe8K1nkeVjNpNoUBxuJv-YXj3Wr_oH86yR31U7w3Jq5j7oxw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2014-09-28 8:35 ` Stanislaw Gruszka 2014-09-28 12:24 ` nick 1 sibling, 0 replies; 6+ messages in thread From: Stanislaw Gruszka @ 2014-09-28 8:35 UTC (permalink / raw) To: Denis Kirjanov Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linux-wireless-u79uwXL29TY76Z2rM5mHXA, users-poMEt7QlJxcwIE2E9O76wjtx2kNaKg5H, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Nicholas Krause On Sun, Sep 28, 2014 at 12:05:30PM +0400, Denis Kirjanov wrote: > Or someone with the hardware has to test and check that... ... on all possible combinations of channel, bandwidth, signal strength, modulation type, ... Stanislaw ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] wireless: Remove unnessary write over of register 11 in rt2800lib.c [not found] ` <CAOJe8K1nkeVjNpNoUBxuJv-YXj3Wr_oH86yR31U7w3Jq5j7oxw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2014-09-28 8:35 ` Stanislaw Gruszka @ 2014-09-28 12:24 ` nick [not found] ` <5427FE15.7080100-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 1 sibling, 1 reply; 6+ messages in thread From: nick @ 2014-09-28 12:24 UTC (permalink / raw) To: Denis Kirjanov, Stanislaw Gruszka Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linux-wireless-u79uwXL29TY76Z2rM5mHXA, users-poMEt7QlJxcwIE2E9O76wjtx2kNaKg5H, linux-kernel-u79uwXL29TY76Z2rM5mHXA On 14-09-28 04:05 AM, Denis Kirjanov wrote: > Or someone with the hardware has to test and check that... > > On 9/28/14, Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote: >> On Sat, Sep 27, 2014 at 05:11:41PM -0400, Nicholas Krause wrote: >>> This removes the unnecessary overwrite of register 11 in the function, >>> rt2800_config_channel as we are already writing a correct value to the >>> register with rt2800_rfcsr_write(rt2x00dev,11.rfcsr). >> What make you sure that overwrite is unnecessary ? >> >>> >>> Signed-off-by: Nicholas Krause <yocto6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >>> --- >>> drivers/net/wireless/rt2x00/rt2800lib.c | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c >>> b/drivers/net/wireless/rt2x00/rt2800lib.c >>> index 893c9d5..fb0ae38 100644 >>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c >>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c >>> @@ -2787,8 +2787,6 @@ static void rt2800_config_channel_rf55xx(struct >>> rt2x00_dev *rt2x00dev, >>> >>> if (rf->channel <= 14) { >>> rt2800_rfcsr_write(rt2x00dev, 10, 0x90); >>> - /* FIXME: RF11 owerwrite ? */ >>> - rt2800_rfcsr_write(rt2x00dev, 11, 0x4A); >> We need a prove that remove is correct, i.e. some reference to >> vendor code or spec that current writing register twice with >> different values is wrong. >> >> NACK for the patch. >> >> Stanislaw >> -- >> To unsubscribe from this list: send the line "unsubscribe netdev" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> I will see if I can either find the vendor code or spec in order to do this correctly. Thanks for the reply through. Nick ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <5427FE15.7080100-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] wireless: Remove unnessary write over of register 11 in rt2800lib.c [not found] ` <5427FE15.7080100-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-09-28 12:34 ` nick 0 siblings, 0 replies; 6+ messages in thread From: nick @ 2014-09-28 12:34 UTC (permalink / raw) To: Denis Kirjanov, Stanislaw Gruszka Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linux-wireless-u79uwXL29TY76Z2rM5mHXA, users-poMEt7QlJxcwIE2E9O76wjtx2kNaKg5H, linux-kernel-u79uwXL29TY76Z2rM5mHXA On 14-09-28 08:24 AM, nick wrote: > > > On 14-09-28 04:05 AM, Denis Kirjanov wrote: >> Or someone with the hardware has to test and check that... >> >> On 9/28/14, Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote: >>> On Sat, Sep 27, 2014 at 05:11:41PM -0400, Nicholas Krause wrote: >>>> This removes the unnecessary overwrite of register 11 in the function, >>>> rt2800_config_channel as we are already writing a correct value to the >>>> register with rt2800_rfcsr_write(rt2x00dev,11.rfcsr). >>> What make you sure that overwrite is unnecessary ? >>> >>>> >>>> Signed-off-by: Nicholas Krause <yocto6-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >>>> --- >>>> drivers/net/wireless/rt2x00/rt2800lib.c | 2 -- >>>> 1 file changed, 2 deletions(-) >>>> >>>> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c >>>> b/drivers/net/wireless/rt2x00/rt2800lib.c >>>> index 893c9d5..fb0ae38 100644 >>>> --- a/drivers/net/wireless/rt2x00/rt2800lib.c >>>> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c >>>> @@ -2787,8 +2787,6 @@ static void rt2800_config_channel_rf55xx(struct >>>> rt2x00_dev *rt2x00dev, >>>> >>>> if (rf->channel <= 14) { >>>> rt2800_rfcsr_write(rt2x00dev, 10, 0x90); >>>> - /* FIXME: RF11 owerwrite ? */ >>>> - rt2800_rfcsr_write(rt2x00dev, 11, 0x4A); >>> We need a prove that remove is correct, i.e. some reference to >>> vendor code or spec that current writing register twice with >>> different values is wrong. >>> >>> NACK for the patch. >>> >>> Stanislaw >>> -- >>> To unsubscribe from this list: send the line "unsubscribe netdev" in >>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> > I will see if I can either find the vendor code or spec in order to do this correctly. Thanks for the reply > through. > Nick > In addition someone banned me from the list yet again. I am getting rather annoyed with this and can someone please remove it. Cheers Nick ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-28 12:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-27 21:11 [PATCH] wireless: Remove unnessary write over of register 11 in rt2800lib.c Nicholas Krause
2014-09-28 7:09 ` [rt2x00-users] " Stanislaw Gruszka
[not found] ` <20140928070923.GA2087-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2014-09-28 8:05 ` Denis Kirjanov
[not found] ` <CAOJe8K1nkeVjNpNoUBxuJv-YXj3Wr_oH86yR31U7w3Jq5j7oxw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-28 8:35 ` Stanislaw Gruszka
2014-09-28 12:24 ` nick
[not found] ` <5427FE15.7080100-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-28 12:34 ` nick
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).