From: David Miller <davem@davemloft.net>
To: hock.leong.kweh@intel.com
Cc: peppe.cavallaro@st.com, rayagond@vayavyalabs.com,
vbridgers2013@gmail.com, wens@csie.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, boon.leong.ong@intel.com,
tobias.johannes.klausmann@mni.thm.de
Subject: Re: [PATCH v2] net: stmmac: fix stmmac_pci_probe failed when CONFIG_HAVE_CLK is selected
Date: Mon, 29 Sep 2014 16:37:20 -0400 (EDT) [thread overview]
Message-ID: <20140929.163720.1059434932375001698.davem@davemloft.net> (raw)
In-Reply-To: <1411738975-20056-1-git-send-email-hock.leong.kweh@intel.com>
From: Kweh Hock Leong <hock.leong.kweh@intel.com>
Date: Fri, 26 Sep 2014 21:42:55 +0800
> From: "Kweh, Hock Leong" <hock.leong.kweh@intel.com>
>
> When the CONFIG_HAVE_CLK is selected for the system, the stmmac_pci_probe
> will fail with dmesg:
> [ 2.167225] stmmaceth 0000:00:14.6: enabling device (0000 -> 0002)
> [ 2.178267] stmmaceth 0000:00:14.6: enabling bus mastering
> [ 2.178436] stmmaceth 0000:00:14.6: irq 24 for MSI/MSI-X
> [ 2.178703] stmmaceth 0000:00:14.6: stmmac_dvr_probe: warning: cannot
> get CSR clock
> [ 2.186503] stmmac_pci_probe: main driver probe failed
> [ 2.194003] stmmaceth 0000:00:14.6: disabling bus mastering
> [ 2.196473] stmmaceth: probe of 0000:00:14.6 failed with error -2
>
> This patch fix the issue by breaking the dependency to devm_clk_get()
> as the CSR clock can be obtained at priv->plat->clk_csr from pci driver.
>
> Reported-by: Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de>
> Signed-off-by: Kweh, Hock Leong <hock.leong.kweh@intel.com>
Applied, thank you.
prev parent reply other threads:[~2014-09-29 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 13:42 [PATCH v2] net: stmmac: fix stmmac_pci_probe failed when CONFIG_HAVE_CLK is selected Kweh Hock Leong
2014-09-29 20:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929.163720.1059434932375001698.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=boon.leong.ong@intel.com \
--cc=hock.leong.kweh@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=rayagond@vayavyalabs.com \
--cc=tobias.johannes.klausmann@mni.thm.de \
--cc=vbridgers2013@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox