* [PATCH 0/5] ARCNET: add support for EAE multi interfac card
@ 2014-09-24 13:41 Michael Grzeschik
2014-09-24 13:41 ` [PATCH 1/5] ARCNET: return IRQ_NONE if the interface isn't running Michael Grzeschik
` (5 more replies)
0 siblings, 6 replies; 11+ messages in thread
From: Michael Grzeschik @ 2014-09-24 13:41 UTC (permalink / raw)
To: netdev; +Cc: linux-kernel, kernel
Hello,
this series adds support for the PLX Bridge based multi interface
pci cards and adds support to change device address on com200xx chips
during runtime.
This series is based on v3.17-rc6.
Thanks,
Michael
Michael Grzeschik (5):
ARCNET: return IRQ_NONE if the interface isn't running
ARCNET: add com20020_set_hwddr to change address
ARCNET: add com20020 PCI IDs with metadata
ARCNET: add support for multi interfaces on com20020
ARCNET: enable eae arcnet card support
drivers/net/arcnet/arcnet.c | 2 +-
drivers/net/arcnet/com20020-pci.c | 369 +++++++++++++++++++++++++++++---------
drivers/net/arcnet/com20020.c | 14 ++
include/linux/com20020.h | 29 +++
4 files changed, 330 insertions(+), 84 deletions(-)
--
2.1.0
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 1/5] ARCNET: return IRQ_NONE if the interface isn't running 2014-09-24 13:41 [PATCH 0/5] ARCNET: add support for EAE multi interfac card Michael Grzeschik @ 2014-09-24 13:41 ` Michael Grzeschik 2014-09-24 13:41 ` [PATCH 2/5] ARCNET: add com20020_set_hwddr to change address Michael Grzeschik ` (4 subsequent siblings) 5 siblings, 0 replies; 11+ messages in thread From: Michael Grzeschik @ 2014-09-24 13:41 UTC (permalink / raw) To: netdev; +Cc: linux-kernel, kernel The interrupt handler needs to return IRQ_NONE in case two devices are used with the shared interrupt handler. Otherwise it could steal interrupts from the other interface. Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> --- drivers/net/arcnet/arcnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/arcnet/arcnet.c b/drivers/net/arcnet/arcnet.c index 3b790de..09de683 100644 --- a/drivers/net/arcnet/arcnet.c +++ b/drivers/net/arcnet/arcnet.c @@ -777,7 +777,7 @@ irqreturn_t arcnet_interrupt(int irq, void *dev_id) ACOMMAND(CFLAGScmd | RESETclear); AINTMASK(0); spin_unlock(&lp->lock); - return IRQ_HANDLED; + return retval; } BUGMSG(D_DURING, "in arcnet_inthandler (status=%Xh, intmask=%Xh)\n", -- 2.1.0 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/5] ARCNET: add com20020_set_hwddr to change address 2014-09-24 13:41 [PATCH 0/5] ARCNET: add support for EAE multi interfac card Michael Grzeschik 2014-09-24 13:41 ` [PATCH 1/5] ARCNET: return IRQ_NONE if the interface isn't running Michael Grzeschik @ 2014-09-24 13:41 ` Michael Grzeschik 2014-09-24 13:41 ` [PATCH 3/5] ARCNET: add com20020 PCI IDs with metadata Michael Grzeschik ` (3 subsequent siblings) 5 siblings, 0 replies; 11+ messages in thread From: Michael Grzeschik @ 2014-09-24 13:41 UTC (permalink / raw) To: netdev; +Cc: linux-kernel, kernel This patch adds com20020_set_hwaddr to make it possible to change the hwaddr on runtime. Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> --- drivers/net/arcnet/com20020.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c index 7b96c5f..1a84378 100644 --- a/drivers/net/arcnet/com20020.c +++ b/drivers/net/arcnet/com20020.c @@ -149,11 +149,25 @@ int com20020_check(struct net_device *dev) return 0; } +static int com20020_set_hwaddr(struct net_device *dev, void *addr) +{ + int ioaddr = dev->base_addr; + struct arcnet_local *lp = netdev_priv(dev); + struct sockaddr *hwaddr = addr; + + memcpy(dev->dev_addr, hwaddr->sa_data, 1); + SET_SUBADR(SUB_NODE); + outb(dev->dev_addr[0], _XREG); + + return 0; +} + const struct net_device_ops com20020_netdev_ops = { .ndo_open = arcnet_open, .ndo_stop = arcnet_close, .ndo_start_xmit = arcnet_send_packet, .ndo_tx_timeout = arcnet_timeout, + .ndo_set_mac_address = com20020_set_hwaddr, .ndo_set_rx_mode = com20020_set_mc_list, }; -- 2.1.0 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/5] ARCNET: add com20020 PCI IDs with metadata 2014-09-24 13:41 [PATCH 0/5] ARCNET: add support for EAE multi interfac card Michael Grzeschik 2014-09-24 13:41 ` [PATCH 1/5] ARCNET: return IRQ_NONE if the interface isn't running Michael Grzeschik 2014-09-24 13:41 ` [PATCH 2/5] ARCNET: add com20020_set_hwddr to change address Michael Grzeschik @ 2014-09-24 13:41 ` Michael Grzeschik 2014-09-24 13:41 ` [PATCH 4/5] ARCNET: add support for multi interfaces on com20020 Michael Grzeschik ` (2 subsequent siblings) 5 siblings, 0 replies; 11+ messages in thread From: Michael Grzeschik @ 2014-09-24 13:41 UTC (permalink / raw) To: netdev; +Cc: linux-kernel, kernel This patch adds metadata for the com20020 to prepare for devices with multiple io address areas with multi card interfaces. Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> --- drivers/net/arcnet/com20020-pci.c | 216 ++++++++++++++++++++++++++++++++------ include/linux/com20020.h | 16 +++ 2 files changed, 197 insertions(+), 35 deletions(-) diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c index 7bb292e..f9e5552 100644 --- a/drivers/net/arcnet/com20020-pci.c +++ b/drivers/net/arcnet/com20020-pci.c @@ -63,6 +63,8 @@ MODULE_LICENSE("GPL"); static int com20020pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) { + struct com20020_pci_channel_map *cm; + struct com20020_pci_card_info *ci; struct net_device *dev; struct arcnet_local *lp; int ioaddr, err; @@ -75,19 +77,15 @@ static int com20020pci_probe(struct pci_dev *pdev, const struct pci_device_id *i dev->netdev_ops = &com20020_netdev_ops; + ci = (struct com20020_pci_card_info *)id->driver_data; + lp = netdev_priv(dev); pci_set_drvdata(pdev, dev); - // SOHARD needs PCI base addr 4 - if (pdev->vendor==0x10B5) { - BUGMSG(D_NORMAL, "SOHARD\n"); - ioaddr = pci_resource_start(pdev, 4); - } - else { - BUGMSG(D_NORMAL, "Contemporary Controls\n"); - ioaddr = pci_resource_start(pdev, 2); - } + cm = &ci->chan_map_tbl[0]; + BUGMSG(D_NORMAL, "%s Controls\n", ci->name); + ioaddr = pci_resource_start(pdev, cm->bar); if (!request_region(ioaddr, ARCNET_TOTAL_SIZE, "com20020-pci")) { BUGMSG(D_INIT, "IO region %xh-%xh already allocated.\n", @@ -105,7 +103,7 @@ static int com20020pci_probe(struct pci_dev *pdev, const struct pci_device_id *i dev->irq = pdev->irq; dev->dev_addr[0] = node; lp->card_name = "PCI COM20020"; - lp->card_flags = id->driver_data; + lp->card_flags = ci->flags; lp->backplane = backplane; lp->clockp = clockp & 7; lp->clockm = clockm & 3; @@ -144,32 +142,180 @@ static void com20020pci_remove(struct pci_dev *pdev) free_netdev(dev); } +static struct com20020_pci_card_info card_info_10mbit = { + .name = "ARC-PCI", + .devcount = 1, + .chan_map_tbl = { + { 2, 0x00, 0x08 }, + }, + .flags = ARC_CAN_10MBIT, +}; + +static struct com20020_pci_card_info card_info_5mbit = { + .name = "ARC-PCI", + .devcount = 1, + .chan_map_tbl = { + { 2, 0x00, 0x08 }, + }, + .flags = ARC_IS_5MBIT, +}; + +static struct com20020_pci_card_info card_info_sohard = { + .name = "PLX-PCI", + .devcount = 1, + /* SOHARD needs PCI base addr 4 */ + .chan_map_tbl = { + {4, 0x00, 0x08}, + }, + .flags = ARC_CAN_10MBIT, +}; + static const struct pci_device_id com20020pci_id_table[] = { - { 0x1571, 0xa001, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, - { 0x1571, 0xa002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, - { 0x1571, 0xa003, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, - { 0x1571, 0xa004, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, - { 0x1571, 0xa005, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, - { 0x1571, 0xa006, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, - { 0x1571, 0xa007, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, - { 0x1571, 0xa008, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, - { 0x1571, 0xa009, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_IS_5MBIT }, - { 0x1571, 0xa00a, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_IS_5MBIT }, - { 0x1571, 0xa00b, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_IS_5MBIT }, - { 0x1571, 0xa00c, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_IS_5MBIT }, - { 0x1571, 0xa00d, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_IS_5MBIT }, - { 0x1571, 0xa00e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_IS_5MBIT }, - { 0x1571, 0xa201, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT }, - { 0x1571, 0xa202, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT }, - { 0x1571, 0xa203, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT }, - { 0x1571, 0xa204, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT }, - { 0x1571, 0xa205, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT }, - { 0x1571, 0xa206, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT }, - { 0x10B5, 0x9030, 0x10B5, 0x2978, 0, 0, ARC_CAN_10MBIT }, - { 0x10B5, 0x9050, 0x10B5, 0x2273, 0, 0, ARC_CAN_10MBIT }, - { 0x14BA, 0x6000, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT }, - { 0x10B5, 0x2200, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ARC_CAN_10MBIT }, - {0,} + { + 0x1571, 0xa001, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + 0, + }, + { + 0x1571, 0xa002, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + 0, + }, + { + 0x1571, 0xa003, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + 0 + }, + { + 0x1571, 0xa004, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + 0, + }, + { + 0x1571, 0xa005, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + 0 + }, + { + 0x1571, 0xa006, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + 0 + }, + { + 0x1571, 0xa007, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + 0 + }, + { + 0x1571, 0xa008, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + 0 + }, + { + 0x1571, 0xa009, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + (kernel_ulong_t)&card_info_5mbit + }, + { + 0x1571, 0xa00a, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + (kernel_ulong_t)&card_info_5mbit + }, + { + 0x1571, 0xa00b, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + (kernel_ulong_t)&card_info_5mbit + }, + { + 0x1571, 0xa00c, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + (kernel_ulong_t)&card_info_5mbit + }, + { + 0x1571, 0xa00d, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + (kernel_ulong_t)&card_info_5mbit + }, + { + 0x1571, 0xa00e, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + (kernel_ulong_t)&card_info_5mbit + }, + { + 0x1571, 0xa201, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + (kernel_ulong_t)&card_info_10mbit + }, + { + 0x1571, 0xa202, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + (kernel_ulong_t)&card_info_10mbit + }, + { + 0x1571, 0xa203, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + (kernel_ulong_t)&card_info_10mbit + }, + { + 0x1571, 0xa204, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + (kernel_ulong_t)&card_info_10mbit + }, + { + 0x1571, 0xa205, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + (kernel_ulong_t)&card_info_10mbit + }, + { + 0x1571, 0xa206, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + (kernel_ulong_t)&card_info_10mbit + }, + { + 0x10B5, 0x9030, + 0x10B5, 0x2978, + 0, 0, + (kernel_ulong_t)&card_info_sohard + }, + { + 0x10B5, 0x9050, + 0x10B5, 0x2273, + 0, 0, + (kernel_ulong_t)&card_info_sohard + }, + { + 0x14BA, 0x6000, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + (kernel_ulong_t)&card_info_10mbit + }, + { + 0x10B5, 0x2200, + PCI_ANY_ID, PCI_ANY_ID, + 0, 0, + (kernel_ulong_t)&card_info_10mbit + }, + { 0, } }; MODULE_DEVICE_TABLE(pci, com20020pci_id_table); diff --git a/include/linux/com20020.h b/include/linux/com20020.h index 5dcfb94..6a1ceca 100644 --- a/include/linux/com20020.h +++ b/include/linux/com20020.h @@ -41,6 +41,22 @@ extern const struct net_device_ops com20020_netdev_ops; #define BUS_ALIGN 1 #endif +#define PLX_PCI_MAX_CARDS 1 + +struct com20020_pci_channel_map { + u32 bar; + u32 offset; + u32 size; /* 0x00 - auto, e.g. length of entire bar */ +}; + +struct com20020_pci_card_info { + const char *name; + int devcount; + + struct com20020_pci_channel_map chan_map_tbl[PLX_PCI_MAX_CARDS]; + + unsigned int flags; +}; #define _INTMASK (ioaddr+BUS_ALIGN*0) /* writable */ #define _STATUS (ioaddr+BUS_ALIGN*0) /* readable */ -- 2.1.0 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 4/5] ARCNET: add support for multi interfaces on com20020 2014-09-24 13:41 [PATCH 0/5] ARCNET: add support for EAE multi interfac card Michael Grzeschik ` (2 preceding siblings ...) 2014-09-24 13:41 ` [PATCH 3/5] ARCNET: add com20020 PCI IDs with metadata Michael Grzeschik @ 2014-09-24 13:41 ` Michael Grzeschik 2014-09-24 13:41 ` [PATCH 5/5] ARCNET: enable eae arcnet card support Michael Grzeschik 2014-09-28 20:44 ` [PATCH 0/5] ARCNET: add support for EAE multi interfac card David Miller 5 siblings, 0 replies; 11+ messages in thread From: Michael Grzeschik @ 2014-09-24 13:41 UTC (permalink / raw) To: netdev; +Cc: linux-kernel, kernel The com20020-pci driver is currently designed to instance one netdev with one pci device. This patch adds support to instance many cards with one pci device, depending on the device data in the private data. Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> --- drivers/net/arcnet/com20020-pci.c | 149 ++++++++++++++++++++++++-------------- include/linux/com20020.h | 15 +++- 2 files changed, 109 insertions(+), 55 deletions(-) diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c index f9e5552..fe87576 100644 --- a/drivers/net/arcnet/com20020-pci.c +++ b/drivers/net/arcnet/com20020-pci.c @@ -38,6 +38,7 @@ #include <linux/pci.h> #include <linux/arcdevice.h> #include <linux/com20020.h> +#include <linux/list.h> #include <asm/io.h> @@ -61,85 +62,125 @@ module_param(clockp, int, 0); module_param(clockm, int, 0); MODULE_LICENSE("GPL"); +static void com20020pci_remove(struct pci_dev *pdev); + static int com20020pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) { - struct com20020_pci_channel_map *cm; struct com20020_pci_card_info *ci; struct net_device *dev; struct arcnet_local *lp; - int ioaddr, err; + struct com20020_priv *priv; + int i, ioaddr, ret; + struct resource *r; if (pci_enable_device(pdev)) return -EIO; - dev = alloc_arcdev(device); - if (!dev) - return -ENOMEM; - - dev->netdev_ops = &com20020_netdev_ops; + priv = devm_kzalloc(&pdev->dev, sizeof(struct com20020_priv), + GFP_KERNEL); ci = (struct com20020_pci_card_info *)id->driver_data; + priv->ci = ci; - lp = netdev_priv(dev); + INIT_LIST_HEAD(&priv->list_dev); - pci_set_drvdata(pdev, dev); - cm = &ci->chan_map_tbl[0]; - BUGMSG(D_NORMAL, "%s Controls\n", ci->name); - ioaddr = pci_resource_start(pdev, cm->bar); + for (i = 0; i < ci->devcount; i++) { + struct com20020_pci_channel_map *cm = &ci->chan_map_tbl[i]; + struct com20020_dev *card; - if (!request_region(ioaddr, ARCNET_TOTAL_SIZE, "com20020-pci")) { - BUGMSG(D_INIT, "IO region %xh-%xh already allocated.\n", - ioaddr, ioaddr + ARCNET_TOTAL_SIZE - 1); - err = -EBUSY; - goto out_dev; - } + dev = alloc_arcdev(device); + if (!dev) { + ret = -ENOMEM; + goto out_port; + } - // Dummy access after Reset - // ARCNET controller needs this access to detect bustype - outb(0x00,ioaddr+1); - inb(ioaddr+1); - - dev->base_addr = ioaddr; - dev->irq = pdev->irq; - dev->dev_addr[0] = node; - lp->card_name = "PCI COM20020"; - lp->card_flags = ci->flags; - lp->backplane = backplane; - lp->clockp = clockp & 7; - lp->clockm = clockm & 3; - lp->timeout = timeout; - lp->hw.owner = THIS_MODULE; - - if (ASTATUS() == 0xFF) { - BUGMSG(D_NORMAL, "IO address %Xh was reported by PCI BIOS, " - "but seems empty!\n", ioaddr); - err = -EIO; - goto out_port; - } - if (com20020_check(dev)) { - err = -EIO; - goto out_port; + dev->netdev_ops = &com20020_netdev_ops; + + lp = netdev_priv(dev); + + BUGMSG(D_NORMAL, "%s Controls\n", ci->name); + ioaddr = pci_resource_start(pdev, cm->bar) + cm->offset; + + r = devm_request_region(&pdev->dev, ioaddr, cm->size, + "com20020-pci"); + if (!r) { + pr_err("IO region %xh-%xh already allocated.\n", + ioaddr, ioaddr + cm->size - 1); + ret = -EBUSY; + goto out_port; + } + + /* Dummy access after Reset + * ARCNET controller needs + * this access to detect bustype + */ + outb(0x00, ioaddr + 1); + inb(ioaddr + 1); + + dev->base_addr = ioaddr; + dev->dev_addr[0] = node; + dev->irq = pdev->irq; + lp->card_name = "PCI COM20020"; + lp->card_flags = ci->flags; + lp->backplane = backplane; + lp->clockp = clockp & 7; + lp->clockm = clockm & 3; + lp->timeout = timeout; + lp->hw.owner = THIS_MODULE; + + if (ASTATUS() == 0xFF) { + pr_err("IO address %Xh is empty!\n", ioaddr); + ret = -EIO; + goto out_port; + } + if (com20020_check(dev)) { + ret = -EIO; + goto out_port; + } + + card = devm_kzalloc(&pdev->dev, sizeof(struct com20020_dev), + GFP_KERNEL); + if (!card) { + pr_err("%s out of memory!\n", __func__); + return -ENOMEM; + } + + card->index = i; + card->pci_priv = priv; + card->dev = dev; + + dev_set_drvdata(&dev->dev, card); + + ret = com20020_found(dev, IRQF_SHARED); + if (ret) + goto out_port; + + list_add(&card->list, &priv->list_dev); } - if ((err = com20020_found(dev, IRQF_SHARED)) != 0) - goto out_port; + pci_set_drvdata(pdev, priv); return 0; out_port: - release_region(ioaddr, ARCNET_TOTAL_SIZE); -out_dev: - free_netdev(dev); - return err; + com20020pci_remove(pdev); + return ret; } static void com20020pci_remove(struct pci_dev *pdev) { - struct net_device *dev = pci_get_drvdata(pdev); - unregister_netdev(dev); - free_irq(dev->irq, dev); - release_region(dev->base_addr, ARCNET_TOTAL_SIZE); - free_netdev(dev); + struct com20020_dev *card, *tmpcard; + struct com20020_priv *priv; + + priv = pci_get_drvdata(pdev); + + list_for_each_entry_safe(card, tmpcard, &priv->list_dev, list) { + struct net_device *dev = card->dev; + + unregister_netdev(dev); + free_irq(dev->irq, dev); + free_netdev(dev); + } } static struct com20020_pci_card_info card_info_10mbit = { diff --git a/include/linux/com20020.h b/include/linux/com20020.h index 6a1ceca..8589899 100644 --- a/include/linux/com20020.h +++ b/include/linux/com20020.h @@ -41,7 +41,7 @@ extern const struct net_device_ops com20020_netdev_ops; #define BUS_ALIGN 1 #endif -#define PLX_PCI_MAX_CARDS 1 +#define PLX_PCI_MAX_CARDS 2 struct com20020_pci_channel_map { u32 bar; @@ -58,6 +58,19 @@ struct com20020_pci_card_info { unsigned int flags; }; +struct com20020_priv { + struct com20020_pci_card_info *ci; + struct list_head list_dev; +}; + +struct com20020_dev { + struct list_head list; + struct net_device *dev; + + struct com20020_priv *pci_priv; + int index; +}; + #define _INTMASK (ioaddr+BUS_ALIGN*0) /* writable */ #define _STATUS (ioaddr+BUS_ALIGN*0) /* readable */ #define _COMMAND (ioaddr+BUS_ALIGN*1) /* standard arcnet commands */ -- 2.1.0 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 5/5] ARCNET: enable eae arcnet card support 2014-09-24 13:41 [PATCH 0/5] ARCNET: add support for EAE multi interfac card Michael Grzeschik ` (3 preceding siblings ...) 2014-09-24 13:41 ` [PATCH 4/5] ARCNET: add support for multi interfaces on com20020 Michael Grzeschik @ 2014-09-24 13:41 ` Michael Grzeschik 2014-09-28 20:44 ` [PATCH 0/5] ARCNET: add support for EAE multi interfac card David Miller 5 siblings, 0 replies; 11+ messages in thread From: Michael Grzeschik @ 2014-09-24 13:41 UTC (permalink / raw) To: netdev; +Cc: linux-kernel, kernel This patch adds support for the EAE arcnet cards which has two Interfaces. Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> --- drivers/net/arcnet/com20020-pci.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c index fe87576..6c99ff0 100644 --- a/drivers/net/arcnet/com20020-pci.c +++ b/drivers/net/arcnet/com20020-pci.c @@ -211,6 +211,16 @@ static struct com20020_pci_card_info card_info_sohard = { .flags = ARC_CAN_10MBIT, }; +static struct com20020_pci_card_info card_info_eae = { + .name = "EAE PLX-PCI", + .devcount = 2, + .chan_map_tbl = { + { 2, 0x00, 0x08 }, + { 2, 0x08, 0x08 } + }, + .flags = ARC_CAN_10MBIT, +}; + static const struct pci_device_id com20020pci_id_table[] = { { 0x1571, 0xa001, @@ -345,6 +355,12 @@ static const struct pci_device_id com20020pci_id_table[] = { (kernel_ulong_t)&card_info_sohard }, { + 0x10B5, 0x9050, + 0x10B5, 0x3292, + 0, 0, + (kernel_ulong_t)&card_info_eae + }, + { 0x14BA, 0x6000, PCI_ANY_ID, PCI_ANY_ID, 0, 0, -- 2.1.0 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] ARCNET: add support for EAE multi interfac card 2014-09-24 13:41 [PATCH 0/5] ARCNET: add support for EAE multi interfac card Michael Grzeschik ` (4 preceding siblings ...) 2014-09-24 13:41 ` [PATCH 5/5] ARCNET: enable eae arcnet card support Michael Grzeschik @ 2014-09-28 20:44 ` David Miller 2014-09-28 21:01 ` David Miller 5 siblings, 1 reply; 11+ messages in thread From: David Miller @ 2014-09-28 20:44 UTC (permalink / raw) To: m.grzeschik; +Cc: netdev, linux-kernel, kernel From: Michael Grzeschik <m.grzeschik@pengutronix.de> Date: Wed, 24 Sep 2014 15:41:48 +0200 > this series adds support for the PLX Bridge based multi interface > pci cards and adds support to change device address on com200xx chips > during runtime. > > This series is based on v3.17-rc6. Series applied to net-next, thanks. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] ARCNET: add support for EAE multi interfac card 2014-09-28 20:44 ` [PATCH 0/5] ARCNET: add support for EAE multi interfac card David Miller @ 2014-09-28 21:01 ` David Miller 2014-09-29 9:07 ` Michael Grzeschik 0 siblings, 1 reply; 11+ messages in thread From: David Miller @ 2014-09-28 21:01 UTC (permalink / raw) To: m.grzeschik; +Cc: netdev, linux-kernel, kernel From: David Miller <davem@davemloft.net> Date: Sun, 28 Sep 2014 16:44:21 -0400 (EDT) > From: Michael Grzeschik <m.grzeschik@pengutronix.de> > Date: Wed, 24 Sep 2014 15:41:48 +0200 > >> this series adds support for the PLX Bridge based multi interface >> pci cards and adds support to change device address on com200xx chips >> during runtime. >> >> This series is based on v3.17-rc6. > > Series applied to net-next, thanks. I had to revert, this breaks the build: drivers/net/arcnet/com20020_cs.c:115:8: error: redefinition of ‘struct com20020_dev’ struct com20020_dev { ^ In file included from drivers/net/arcnet/com20020_cs.c:43:0: include/linux/com20020.h:66:8: note: originally defined here struct com20020_dev { ^ make[3]: *** [drivers/net/arcnet/com20020_cs.o] Error 1 make[2]: *** [drivers/net/arcnet] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [drivers/net] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [drivers] Error 2 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] ARCNET: add support for EAE multi interfac card 2014-09-28 21:01 ` David Miller @ 2014-09-29 9:07 ` Michael Grzeschik 0 siblings, 0 replies; 11+ messages in thread From: Michael Grzeschik @ 2014-09-29 9:07 UTC (permalink / raw) To: David Miller; +Cc: m.grzeschik, netdev, linux-kernel, kernel On Sun, Sep 28, 2014 at 05:01:50PM -0400, David Miller wrote: > From: David Miller <davem@davemloft.net> > Date: Sun, 28 Sep 2014 16:44:21 -0400 (EDT) > > > From: Michael Grzeschik <m.grzeschik@pengutronix.de> > > Date: Wed, 24 Sep 2014 15:41:48 +0200 > > > >> this series adds support for the PLX Bridge based multi interface > >> pci cards and adds support to change device address on com200xx chips > >> during runtime. > >> > >> This series is based on v3.17-rc6. > > > > Series applied to net-next, thanks. > > I had to revert, this breaks the build: > > drivers/net/arcnet/com20020_cs.c:115:8: error: redefinition of ‘struct com20020_dev’ > struct com20020_dev { > ^ > In file included from drivers/net/arcnet/com20020_cs.c:43:0: > include/linux/com20020.h:66:8: note: originally defined here > struct com20020_dev { > ^ > make[3]: *** [drivers/net/arcnet/com20020_cs.o] Error 1 > make[2]: *** [drivers/net/arcnet] Error 2 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [drivers/net] Error 2 > make[1]: *** Waiting for unfinished jobs.... > make: *** [drivers] Error 2 Oh, I didn't look into the other com20020 drivers. I will fix it and send v2. Thanks, Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 0/5] ARCNET: add support for EAE multi interfac card @ 2014-09-24 11:01 Michael Grzeschik 2014-09-24 13:29 ` Michael Grzeschik 0 siblings, 1 reply; 11+ messages in thread From: Michael Grzeschik @ 2014-09-24 11:01 UTC (permalink / raw) To: netdev; +Cc: linux-kernel, kernel This series adds support for the PLX bridge based multi interface pci cards and adds support to change device address on com200xx chips during runtime. Thanks, Michael Michael Grzeschik (5): ARCNET: return IRQ_NONE if the interface isn't running ARCNET: add com20020_set_hwddr to change address ARCNET: add com20020 PCI IDs with metadata ARCNET: add support for multi interfaces on com20020 ARCNET: enable eae arcnet card support drivers/net/arcnet/arcnet.c | 2 +- drivers/net/arcnet/com20020-pci.c | 369 +++++++++++++++++++++++++++++--------- drivers/net/arcnet/com20020.c | 14 ++ include/linux/com20020.h | 29 +++ 4 files changed, 330 insertions(+), 84 deletions(-) -- 2.1.0 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/5] ARCNET: add support for EAE multi interfac card 2014-09-24 11:01 Michael Grzeschik @ 2014-09-24 13:29 ` Michael Grzeschik 0 siblings, 0 replies; 11+ messages in thread From: Michael Grzeschik @ 2014-09-24 13:29 UTC (permalink / raw) To: netdev; +Cc: linux-kernel, kernel Hi, On Wed, Sep 24, 2014 at 01:01:58PM +0200, Michael Grzeschik wrote: > This series adds support for the PLX bridge based multi interface > pci cards and adds support to change device address on com200xx chips > during runtime. > > Thanks, > Michael > > Michael Grzeschik (5): > ARCNET: return IRQ_NONE if the interface isn't running > ARCNET: add com20020_set_hwddr to change address > ARCNET: add com20020 PCI IDs with metadata > ARCNET: add support for multi interfaces on com20020 > ARCNET: enable eae arcnet card support > > drivers/net/arcnet/arcnet.c | 2 +- > drivers/net/arcnet/com20020-pci.c | 369 +++++++++++++++++++++++++++++--------- > drivers/net/arcnet/com20020.c | 14 ++ > include/linux/com20020.h | 29 +++ > 4 files changed, 330 insertions(+), 84 deletions(-) > > -- > 2.1.0 This series was based on v3.16 and does not apply on master. Who could expect somebody else be patching the arcnet dir in this century. :) Will send a newer series in some minutes. Michael Grzeschik -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2014-09-29 9:07 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-09-24 13:41 [PATCH 0/5] ARCNET: add support for EAE multi interfac card Michael Grzeschik 2014-09-24 13:41 ` [PATCH 1/5] ARCNET: return IRQ_NONE if the interface isn't running Michael Grzeschik 2014-09-24 13:41 ` [PATCH 2/5] ARCNET: add com20020_set_hwddr to change address Michael Grzeschik 2014-09-24 13:41 ` [PATCH 3/5] ARCNET: add com20020 PCI IDs with metadata Michael Grzeschik 2014-09-24 13:41 ` [PATCH 4/5] ARCNET: add support for multi interfaces on com20020 Michael Grzeschik 2014-09-24 13:41 ` [PATCH 5/5] ARCNET: enable eae arcnet card support Michael Grzeschik 2014-09-28 20:44 ` [PATCH 0/5] ARCNET: add support for EAE multi interfac card David Miller 2014-09-28 21:01 ` David Miller 2014-09-29 9:07 ` Michael Grzeschik -- strict thread matches above, loose matches on Subject: below -- 2014-09-24 11:01 Michael Grzeschik 2014-09-24 13:29 ` Michael Grzeschik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).