netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: "luwei.zhou@freescale.com" <luwei.zhou@freescale.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
	"bhutchings@solarflare.com" <bhutchings@solarflare.com>,
	"Fabio.Estevam@freescale.com" <Fabio.Estevam@freescale.com>,
	"fugang.duan@freescale.com" <fugang.duan@freescale.com>,
	"Frank.Li@freescale.com" <Frank.Li@freescale.com>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: Re: [PATCH v2 3/4] ptp: Add PTP_PF_PPS enumeration to ptp_pin_function.
Date: Mon, 29 Sep 2014 15:25:51 +0200	[thread overview]
Message-ID: <20140929132551.GA27428@netboy> (raw)
In-Reply-To: <ee73b9239ea9417e976fdf2c51b2fd60@BY2PR03MB441.namprd03.prod.outlook.com>

On Mon, Sep 29, 2014 at 09:38:44AM +0000, luwei.zhou@freescale.com wrote:
> My understanding is n_pins should be 1 because there is only one PPS output 

The field 'n_pins' is the number of *physical* *programmable* pins.

If the PPS signal on your SoC can appear on any of 4 different pins,
then n_pins should be 4.

If the PPS signal on your SoC can only appear on one pin,
then n_pins should be 0 (zero).

Please see:

 Documentation/ptp/testptp.c
 include/linux/ptp_clock_kernel.h
 include/uapi/linux/ptp_clock.h

Thanks,
Richard

  reply	other threads:[~2014-09-29 13:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-28  4:20 [PATCH v2 0/4] net: fec: ptp: Add FEC PPS ouput support Luwei Zhou
2014-09-28  4:20 ` [PATCH v2 1/4] net: fec: ptp: Use the 31-bit ptp timer Luwei Zhou
2014-09-28  4:20 ` [PATCH v2 2/4] net: fec: ptp: Use hardware algorithm to adjust PTP counter Luwei Zhou
2014-09-29  2:13   ` fugang.duan
2014-09-28  4:20 ` [PATCH v2 3/4] ptp: Add PTP_PF_PPS enumeration to ptp_pin_function Luwei Zhou
2014-09-29  8:56   ` Richard Cochran
2014-09-29  9:38     ` luwei.zhou
2014-09-29 13:25       ` Richard Cochran [this message]
2014-09-28  4:20 ` [PATCH v2 4/4] net: fec: ptp: Enalbe PPS ouput based on ptp clock Luwei Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140929132551.GA27428@netboy \
    --to=richardcochran@gmail.com \
    --cc=Fabio.Estevam@freescale.com \
    --cc=Frank.Li@freescale.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=fugang.duan@freescale.com \
    --cc=luwei.zhou@freescale.com \
    --cc=netdev@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).