From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: Yuval.Mintz@qlogic.com, therbert@google.com, netdev@vger.kernel.org
Subject: Re: How exactly does CHECKSUM_COMPLETE works?
Date: Tue, 30 Sep 2014 16:14:24 -0400 (EDT) [thread overview]
Message-ID: <20140930.161424.679705969149272577.davem@davemloft.net> (raw)
In-Reply-To: <1412105832.30721.95.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 30 Sep 2014 12:37:12 -0700
> On Tue, 2014-09-30 at 12:22 -0700, Eric Dumazet wrote:
>> On Tue, 2014-09-30 at 19:05 +0000, Yuval Mintz wrote:
>>
>> > Can you pinpoint me to what exactly in the code corrects NAPI_GRO_CB(skb)->csum
>> > by negating the ipv4 part in the ones' complete checksum?
>> >
>> > E.g., for ipv6 [in ipv6_gro_receive()] I can see that skb_gro_postpull_rcsum() is
>> > called after pulling the ipv6 header [and before proceeding to the next protocol],
>> > but I can't seem to find anything similar to this for ipv4 [in inet_gro_receive()].
>> >
>>
>>
>> IPv4 header is supposed to have a 0 checksum ;)
>>
>
> Or if you prefer :
Someone please submit this formally :)
next prev parent reply other threads:[~2014-09-30 20:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 12:51 How exactly does CHECKSUM_COMPLETE works? Yuval Mintz
2014-09-30 14:59 ` Tom Herbert
2014-09-30 16:58 ` Alexei Starovoitov
2014-09-30 18:48 ` David Miller
2014-09-30 19:05 ` Yuval Mintz
2014-09-30 19:22 ` Eric Dumazet
2014-09-30 19:37 ` Eric Dumazet
2014-09-30 20:14 ` David Miller [this message]
2014-10-01 5:12 ` [PATCH net-next] ipv4: mentions skb_gro_postpull_rcsum() in inet_gro_receive() Eric Dumazet
2014-10-01 17:44 ` David Miller
2014-09-30 20:19 ` How exactly does CHECKSUM_COMPLETE works? Yuval Mintz
2014-09-30 20:32 ` Yuval Mintz
2014-10-01 5:15 ` Tom Herbert
2014-10-01 5:17 ` Yuval Mintz
2014-10-01 5:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930.161424.679705969149272577.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Yuval.Mintz@qlogic.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox