From: Antoine Tenart <antoine.tenart@free-electrons.com>
To: David Miller <davem@davemloft.net>
Cc: antoine.tenart@free-electrons.com,
sebastian.hesselbarth@gmail.com,
alexandre.belloni@free-electrons.com,
thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
jszhang@marvell.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 02/10] net: pxa168_eth: add device tree support
Date: Tue, 30 Sep 2014 16:28:50 +0200 [thread overview]
Message-ID: <20140930142850.GA30288@kwain> (raw)
In-Reply-To: <20140929.160436.1932620234954504510.davem@davemloft.net>
David,
On Mon, Sep 29, 2014 at 04:04:36PM -0400, David Miller wrote:
> From: Antoine Tenart <antoine.tenart@free-electrons.com>
> Date: Fri, 26 Sep 2014 16:33:48 +0200
>
> > @@ -1603,6 +1620,12 @@ static int pxa168_eth_suspend(struct platform_device *pdev, pm_message_t state)
> > #define pxa168_eth_suspend NULL
> > #endif
> >
> > +static const struct of_device_id pxa168_eth_of_match[] = {
> > + { .compatible = "marvell,pxa168-eth" },
> > + { },
> > +};
> > +MODULE_DEVICE_TABLE(of, pxa168_eth_of_match)
> > +
> > static struct platform_driver pxa168_eth_driver = {
>
> You didn't even compile test this change with module support enabled.
>
> drivers/net/ethernet/marvell/pxa168_eth.c:1670:1: error: expected ‘,’ or ‘;’ before ‘static’
>
> MODULE_DEVICE_TABLE() must be completed with a trailing ';'
Oops, thanks for spotting this!
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-30 14:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 14:33 [PATCH v6 00/10] ARM: Berlin: Ethernet support Antoine Tenart
2014-09-26 14:33 ` [PATCH v5 01/10] net: pxa168_eth: clean up Antoine Tenart
2014-09-26 14:33 ` [PATCH v5 02/10] net: pxa168_eth: add device tree support Antoine Tenart
2014-09-29 20:04 ` David Miller
2014-09-30 14:28 ` Antoine Tenart [this message]
2014-09-26 14:33 ` [PATCH v5 03/10] Documentation: bindings: net: add the Marvell PXA168 Ethernet controller Antoine Tenart
2014-09-26 14:33 ` [PATCH v5 04/10] net: pxa168_eth: fix Ethernet flow control status Antoine Tenart
2014-09-26 14:33 ` [PATCH v5 05/10] net: pxa168_eth: set the mac address on the Ethernet controller Antoine Tenart
2014-09-26 14:33 ` [PATCH v5 06/10] net: pxa168_eth: rework the MAC address setup Antoine Tenart
2014-09-26 14:33 ` [PATCH v5 07/10] net: pxa168_eth: allow Berlin SoCs to use the pxa168_eth driver Antoine Tenart
2014-09-26 14:33 ` [PATCH v5 08/10] net: pxa168_eth: allow to compile the pxa168_eth driver for tests Antoine Tenart
2014-09-26 14:33 ` [PATCH v5 09/10] ARM: dts: berlin: add the Ethernet node Antoine Tenart
2014-09-26 17:25 ` Sergei Shtylyov
2014-09-29 14:34 ` Sebastian Hesselbarth
2014-09-26 14:33 ` [PATCH v5 10/10] ARM: dts: berlin: enable the Ethernet port on the BG2Q DMP Antoine Tenart
2014-09-26 14:37 ` [PATCH v6 00/10] ARM: Berlin: Ethernet support Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930142850.GA30288@kwain \
--to=antoine.tenart@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=zmxu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).