From: Wolfram Sang <wsa@the-dreams.de>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Roger Quadros <rogerq@ti.com>,
wg@grandegger.com, tony@atomide.com, tglx@linutronix.de,
mugunthanvnm@ti.com, george.cherian@ti.com, balbi@ti.com,
nsekhar@ti.com, nm@ti.com, sergei.shtylyov@cogentembedded.com,
linux-omap@vger.kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism
Date: Tue, 30 Sep 2014 17:25:50 +0200 [thread overview]
Message-ID: <20140930152550.GR1325@katana> (raw)
In-Reply-To: <542AC5B2.9040406@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
> Yes, but syscon_regmap_lookup_by_phandle() doesn't need any support for
> additional parameters. Have a look at:
>
> drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
>
> First get the regmap, then the 1st argument is the offset in the regmap,
> the 2nd and 3rd could be the bits.
So, for one driver the extra arguments are: <reg> <start_bit> <stop_bit>
For another driver (the stmmac example): <reg_offset> <reg_shift>
Phew... Then we should really have a "syscon-raminit" property probably,
so that at least plain "syscon" has a consistent syntax?
>
> > So, I'd rather drop additional arguments.
> >
> > Why would you like to have it encoded in DT?
>
> Where put the information then? Into the driver, but where do you get
> the reference which instance of the DCAN you are, so that you can look
> up the correct bits?
Agreed. I thought we had this information in the driver already, but we
haven't...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-30 15:25 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 14:31 [PATCH v2 0/3] net: can: Use syscon regmap for TI specific RAMINIT register Roger Quadros
2014-09-09 14:31 ` [PATCH v2 1/3] can: c_can_platform: Fix c_can_hw_raminit_ti() and add timeout Roger Quadros
2014-09-09 14:34 ` Marc Kleine-Budde
2014-09-09 14:39 ` Roger Quadros
2014-09-16 14:13 ` Marc Kleine-Budde
2014-09-09 14:34 ` Nishanth Menon
2014-09-09 14:45 ` Roger Quadros
2014-09-09 14:51 ` Nishanth Menon
2014-09-09 14:54 ` Roger Quadros
2014-09-09 14:31 ` [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism Roger Quadros
2014-09-30 13:26 ` Wolfram Sang
2014-09-30 13:33 ` Roger Quadros
2014-09-30 13:52 ` Wolfram Sang
2014-09-30 13:58 ` Roger Quadros
2014-09-30 14:19 ` Wolfram Sang
2014-09-30 14:22 ` Marc Kleine-Budde
2014-09-30 14:49 ` Wolfram Sang
2014-09-30 15:01 ` Marc Kleine-Budde
2014-09-30 15:25 ` Wolfram Sang [this message]
2014-09-30 16:04 ` Marc Kleine-Budde
2014-10-01 8:45 ` Roger Quadros
2014-10-01 8:47 ` Marc Kleine-Budde
2014-10-01 9:06 ` Roger Quadros
2014-10-01 10:01 ` Marc Kleine-Budde
2014-10-01 10:12 ` Roger Quadros
2014-10-01 10:26 ` Marc Kleine-Budde
2014-10-01 10:43 ` Wolfram Sang
2014-10-01 10:57 ` Roger Quadros
2014-10-01 11:06 ` Marc Kleine-Budde
2014-10-01 11:10 ` Wolfram Sang
2014-10-01 11:11 ` Marc Kleine-Budde
2014-09-30 13:45 ` Marc Kleine-Budde
2014-09-30 14:02 ` Roger Quadros
2014-09-30 14:11 ` Marc Kleine-Budde
2014-09-09 14:31 ` [PATCH v2 3/3] net: can: c_can: Add support for START pulse in RAMINIT sequence Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930152550.GR1325@katana \
--to=wsa@the-dreams.de \
--cc=balbi@ti.com \
--cc=george.cherian@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=rogerq@ti.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).