From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Eli Cohen <eli@dev.mellanox.co.il>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
ogerlitz@mellanox.com, yevgenyp@mellanox.com,
Eli Cohen <eli@mellanox.com>
Subject: Re: [PATCH net-next 2/4] net/mlx5_core: Use hardware registers description header file
Date: Tue, 30 Sep 2014 08:34:49 -0700 [thread overview]
Message-ID: <20140930153445.GA9303@localhost.westell.com> (raw)
In-Reply-To: <1412082135-30229-4-git-send-email-eli@mellanox.com>
On Tue, Sep 30, 2014 at 04:02:13PM +0300, Eli Cohen wrote:
> Add an auto generated header file that describes hardware registers along with
> set of macros that set/get values. The macros do static checks to avoid
> overflow, handle endianess, and overall provide a clean way to code commands.
>
> A few commands were removed since they are not supported currently and will be
> added when support is available.
>
> Signed-off-by: Eli Cohen <eli@mellanox.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 36 -
> drivers/net/ethernet/mellanox/mlx5/core/qp.c | 3 -
> include/linux/mlx5/device.h | 74 +
> include/linux/mlx5/driver.h | 76 +-
> include/linux/mlx5/mlx5_ifc.h | 4464 +++++++++++++++++++++++++
> 5 files changed, 4539 insertions(+), 114 deletions(-)
I find hard time believing that all of 4k auto generated macros
are actually used. Could you trim it down to only usable bits?
next prev parent reply other threads:[~2014-09-30 15:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 13:02 [PATCH net-next 0/4] mlx5 update for 3.18 Eli Cohen
2014-09-30 13:02 ` Eli Cohen
2014-09-30 13:02 ` [PATCH net-next 1/4] net/mlx5_core: Update device capabilities handling Eli Cohen
2014-09-30 13:02 ` [PATCH net-next 2/4] net/mlx5_core: Use hardware registers description header file Eli Cohen
2014-09-30 15:34 ` Alexei Starovoitov [this message]
2014-09-30 19:34 ` Eli Cohen
2014-09-30 20:13 ` David Miller
2014-10-01 13:47 ` Eli Cohen
2014-09-30 13:02 ` [PATCH net-next 3/4] net/mlx5_core: use set/get macros in device caps Eli Cohen
2014-09-30 13:02 ` [PATCH net-next 4/4] net/mlx5_core: Identify resources by their type Eli Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930153445.GA9303@localhost.westell.com \
--to=alexei.starovoitov@gmail.com \
--cc=davem@davemloft.net \
--cc=eli@dev.mellanox.co.il \
--cc=eli@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).