From: "John W. Linville" <linville@tuxdriver.com>
To: Mark Brown <broonie@kernel.org>
Cc: Jouni Malinen <j@w1.fi>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linaro-kernel@lists.linaro.org
Subject: Re: [PATCH] hostap: proc: Remove unused variable
Date: Tue, 30 Sep 2014 12:56:26 -0400 [thread overview]
Message-ID: <20140930165626.GD11919@tuxdriver.com> (raw)
In-Reply-To: <1410909415-11661-1-git-send-email-broonie@kernel.org>
On Tue, Sep 16, 2014 at 04:16:55PM -0700, Mark Brown wrote:
> Since "hostap: proc: substitute loops by %*phN" (62c5afb8e388) the
> variable i has been unused in prism2_bss_list_proc_show() so remove it.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> drivers/net/wireless/hostap/hostap_proc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/hostap/hostap_proc.c b/drivers/net/wireless/hostap/hostap_proc.c
> index 3a23a6d..dd84557 100644
> --- a/drivers/net/wireless/hostap/hostap_proc.c
> +++ b/drivers/net/wireless/hostap/hostap_proc.c
> @@ -168,7 +168,6 @@ static int prism2_bss_list_proc_show(struct seq_file *m, void *v)
> local_info_t *local = m->private;
> struct list_head *ptr = v;
> struct hostap_bss_info *bss;
> - int i;
>
> if (ptr == &local->bss_list) {
> seq_printf(m, "#BSSID\tlast_update\tcount\tcapab_info\tSSID(txt)\t"
> --
> 2.1.0
What tree are you using? In wireless-next, I still see a loop in
that function using i as an index variable.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2014-09-30 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 23:16 [PATCH] hostap: proc: Remove unused variable Mark Brown
2014-09-30 16:56 ` John W. Linville [this message]
[not found] ` <20140930165626.GD11919-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-09-30 22:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930165626.GD11919@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=broonie@kernel.org \
--cc=j@w1.fi \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).