* [PATCH] hostap: proc: Remove unused variable
@ 2014-09-16 23:16 Mark Brown
2014-09-30 16:56 ` John W. Linville
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2014-09-16 23:16 UTC (permalink / raw)
To: Jouni Malinen, John W. Linville
Cc: linux-wireless, netdev, linaro-kernel, Mark Brown
Since "hostap: proc: substitute loops by %*phN" (62c5afb8e388) the
variable i has been unused in prism2_bss_list_proc_show() so remove it.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/net/wireless/hostap/hostap_proc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/hostap/hostap_proc.c b/drivers/net/wireless/hostap/hostap_proc.c
index 3a23a6d..dd84557 100644
--- a/drivers/net/wireless/hostap/hostap_proc.c
+++ b/drivers/net/wireless/hostap/hostap_proc.c
@@ -168,7 +168,6 @@ static int prism2_bss_list_proc_show(struct seq_file *m, void *v)
local_info_t *local = m->private;
struct list_head *ptr = v;
struct hostap_bss_info *bss;
- int i;
if (ptr == &local->bss_list) {
seq_printf(m, "#BSSID\tlast_update\tcount\tcapab_info\tSSID(txt)\t"
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hostap: proc: Remove unused variable
2014-09-16 23:16 [PATCH] hostap: proc: Remove unused variable Mark Brown
@ 2014-09-30 16:56 ` John W. Linville
[not found] ` <20140930165626.GD11919-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: John W. Linville @ 2014-09-30 16:56 UTC (permalink / raw)
To: Mark Brown; +Cc: Jouni Malinen, linux-wireless, netdev, linaro-kernel
On Tue, Sep 16, 2014 at 04:16:55PM -0700, Mark Brown wrote:
> Since "hostap: proc: substitute loops by %*phN" (62c5afb8e388) the
> variable i has been unused in prism2_bss_list_proc_show() so remove it.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> drivers/net/wireless/hostap/hostap_proc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/hostap/hostap_proc.c b/drivers/net/wireless/hostap/hostap_proc.c
> index 3a23a6d..dd84557 100644
> --- a/drivers/net/wireless/hostap/hostap_proc.c
> +++ b/drivers/net/wireless/hostap/hostap_proc.c
> @@ -168,7 +168,6 @@ static int prism2_bss_list_proc_show(struct seq_file *m, void *v)
> local_info_t *local = m->private;
> struct list_head *ptr = v;
> struct hostap_bss_info *bss;
> - int i;
>
> if (ptr == &local->bss_list) {
> seq_printf(m, "#BSSID\tlast_update\tcount\tcapab_info\tSSID(txt)\t"
> --
> 2.1.0
What tree are you using? In wireless-next, I still see a loop in
that function using i as an index variable.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hostap: proc: Remove unused variable
[not found] ` <20140930165626.GD11919-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
@ 2014-09-30 22:56 ` Mark Brown
0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-09-30 22:56 UTC (permalink / raw)
To: John W. Linville
Cc: Jouni Malinen, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA,
linaro-kernel-cunTk1MwBs8s++Sfvej+rw
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
On Tue, Sep 30, 2014 at 12:56:26PM -0400, John W. Linville wrote:
> On Tue, Sep 16, 2014 at 04:16:55PM -0700, Mark Brown wrote:
> > Since "hostap: proc: substitute loops by %*phN" (62c5afb8e388) the
> > variable i has been unused in prism2_bss_list_proc_show() so remove it.
> What tree are you using? In wireless-next, I still see a loop in
> that function using i as an index variable.
This was in -next for whatever day I sent that.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-30 22:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-16 23:16 [PATCH] hostap: proc: Remove unused variable Mark Brown
2014-09-30 16:56 ` John W. Linville
[not found] ` <20140930165626.GD11919-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2014-09-30 22:56 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).