From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [net-next PATCH] dql: add a burst attribute Date: Tue, 30 Sep 2014 23:29:55 +0200 Message-ID: <20140930232955.406a92da@redhat.com> References: <20140930085114.24043.81310.stgit@dragon> <1412080482.30721.68.camel@edumazet-glaptop2.roam.corp.google.com> <1412081485.30721.75.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, "David S. Miller" , Tom Herbert , Hannes Frederic Sowa , Florian Westphal , Daniel Borkmann , Jamal Hadi Salim , Alexander Duyck , John Fastabend , Dave Taht , toke@toke.dk, brouer@redhat.com To: Eric Dumazet Return-path: Received: from mx1.redhat.com ([209.132.183.28]:30429 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbaI3VaX (ORCPT ); Tue, 30 Sep 2014 17:30:23 -0400 In-Reply-To: <1412081485.30721.75.camel@edumazet-glaptop2.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 30 Sep 2014 05:51:25 -0700 Eric Dumazet wrote: > From: Eric Dumazet > > Add a new dql attribute, to control how much packets we are allowed to > burst from qdisc to device. > > Signed-off-by: Eric Dumazet > --- > Jesper, please consider using this instead of 7 or 8 values you hard coded. The hard coded budget was only a safe guard. I didn't want to export it (as we can never remove it then), I plan to remove it or replace it with something else. -- Best regards, Jesper Dangaard Brouer MSc.CS, Sr. Network Kernel Developer at Red Hat Author of http://www.iptv-analyzer.org LinkedIn: http://www.linkedin.com/in/brouer