* [PATCH v2] net: ll_temac: Remove unnecessary ether_setup after alloc_etherdev
@ 2014-10-01 9:01 Michal Simek
2014-10-01 19:01 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Michal Simek @ 2014-10-01 9:01 UTC (permalink / raw)
To: linux-kernel, monstr
Cc: Subbaraya Sundeep Bhatta, David S. Miller, Manuel Schölling,
Paul Gortmaker, Julia Lawall, Joe Perches, Ricardo Ribalda,
Eric Dumazet, netdev, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]
From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com>
Calling ether_setup is redundant since alloc_etherdev calls it.
Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
Changes in v2:
- Remove axienet because it is already applied in separate patch
https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=c706471b2601d1c9058e7b866db77f6eb7dd37af
drivers/net/ethernet/xilinx/ll_temac_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index fda5891835d4..629077050fce 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -1012,7 +1012,6 @@ static int temac_of_probe(struct platform_device *op)
if (!ndev)
return -ENOMEM;
- ether_setup(ndev);
platform_set_drvdata(op, ndev);
SET_NETDEV_DEV(ndev, &op->dev);
ndev->flags &= ~IFF_MULTICAST; /* clear multicast */
--
1.8.2.3
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] net: ll_temac: Remove unnecessary ether_setup after alloc_etherdev
2014-10-01 9:01 [PATCH v2] net: ll_temac: Remove unnecessary ether_setup after alloc_etherdev Michal Simek
@ 2014-10-01 19:01 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-10-01 19:01 UTC (permalink / raw)
To: michal.simek
Cc: linux-kernel, monstr, subbaraya.sundeep.bhatta, manuel.schoelling,
paul.gortmaker, Julia.Lawall, joe, ricardo.ribalda, edumazet,
netdev, linux-arm-kernel
From: Michal Simek <michal.simek@xilinx.com>
Date: Wed, 1 Oct 2014 11:01:17 +0200
> From: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com>
>
> Calling ether_setup is redundant since alloc_etherdev calls it.
>
> Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Changes in v2:
> - Remove axienet because it is already applied in separate patch
> https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=c706471b2601d1c9058e7b866db77f6eb7dd37af
Applied, thanks Michal.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-01 19:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-01 9:01 [PATCH v2] net: ll_temac: Remove unnecessary ether_setup after alloc_etherdev Michal Simek
2014-10-01 19:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).