From: "Michael Büsch" <m@bues.ch>
To: Pramod Gurav <pramod.gurav@smartplayin.com>
Cc: Paul Bolle <pebolle@tiscali.nl>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] ssb: Fix Sparse error in main
Date: Wed, 1 Oct 2014 15:27:05 +0200 [thread overview]
Message-ID: <20141001152705.02f4f34e@wiggum> (raw)
In-Reply-To: <542BAFB3.6030207@smartplayin.com>
[-- Attachment #1: Type: text/plain, Size: 1845 bytes --]
On Wed, 01 Oct 2014 13:09:31 +0530
Pramod Gurav <pramod.gurav@smartplayin.com> wrote:
> On Wednesday 01 October 2014 12:59 PM, Paul Bolle wrote:
> > On Wed, 2014-10-01 at 12:36 +0530, Pramod Gurav wrote:
> >> This change fixes below sparse error:
> >>
> >> drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus'
> >> was not declared. Should it be static?
> >>
> >> Cc: Michael Buesch <m@bues.ch>
> >> Cc: netdev@vger.kernel.org
> >> Signed-off-by: Pramod Gurav <pramod.gurav@smartplayin.com>
> >> ---
> >> drivers/ssb/ssb_private.h | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/ssb/ssb_private.h b/drivers/ssb/ssb_private.h
> >> index eb507a5..86bbbe3 100644
> >> --- a/drivers/ssb/ssb_private.h
> >> +++ b/drivers/ssb/ssb_private.h
> >> @@ -193,6 +193,7 @@ extern struct ssb_bus *ssb_pci_dev_to_bus(struct pci_dev *pdev);
> >> int ssb_for_each_bus_call(unsigned long data,
> >> int (*func)(struct ssb_bus *bus, unsigned long data));
> >> extern struct ssb_bus *ssb_pcmcia_dev_to_bus(struct pcmcia_device *pdev);
> >> +struct ssb_bus *ssb_sdio_func_to_bus(struct sdio_func *func);
> >>
> >> struct ssb_freeze_context {
> >> /* Pointer to the bus */
> >
> > To me this looked like an odd way to silence that warning. So I dug a
> > bit further.
> >
> > ssb_sdio_func_to_bus() was added in commit 24ea602e183c ("ssb: Implement
> > SDIO host bus support"). So it was added in release v2.6.32. I found no
> > evidence this function was ever used. Can't it be removed?
> >
> Thanks Paul for review. Initially I too had greped for this function in
> kernel and found noone using it. But I thought this function might be
> useful in future. About removing it, may be original author can tell.
If it's unused, please remove it.
--
Michael
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-10-01 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 7:06 [PATCH] ssb: Fix Sparse error in main Pramod Gurav
2014-10-01 7:29 ` Paul Bolle
2014-10-01 7:39 ` Pramod Gurav
2014-10-01 13:27 ` Michael Büsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001152705.02f4f34e@wiggum \
--to=m@bues.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=pramod.gurav@smartplayin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).