From: Jiri Pirko <jiri@resnulli.us>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] iproute2: Add support for IPv6 VTI tunnels to ip6tunnel
Date: Thu, 2 Oct 2014 11:11:40 +0200 [thread overview]
Message-ID: <20141002091140.GA1865@nanopsycho.orion> (raw)
In-Reply-To: <20141002084820.GF6390@secunet.com>
Thu, Oct 02, 2014 at 10:48:20AM CEST, steffen.klassert@secunet.com wrote:
>On Thu, Oct 02, 2014 at 10:41:09AM +0200, Jiri Pirko wrote:
>> Fri, Sep 26, 2014 at 09:10:56AM CEST, steffen.klassert@secunet.com wrote:
>> >
>> >@@ -459,11 +462,14 @@ static int do_add(int cmd, int argc, char **argv)
>> > switch (p.proto) {
>> > case IPPROTO_IPIP:
>> > case IPPROTO_IPV6:
>> >+ if (p.i_flags != VTI_ISVTI)
>> >+ return tnl_add_ioctl(cmd, "ip6_vti0", p.name, &p);
>> ^ Wouldn't it be more
>> consistent to not to use
>> the underscore?
>
>The ipv4 version of vti uses ip_vti0, so I tried to be consistent
>with that.
Okay, fine with me.
next prev parent reply other threads:[~2014-10-02 9:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 7:10 [PATCH 1/2] iproute2: Add support for IPv6 VTI tunnels to ip6tunnel Steffen Klassert
2014-09-26 7:11 ` [PATCH 2/2] iproute2: VTI6 support for ip -6 link command Steffen Klassert
2014-10-02 8:41 ` [PATCH 1/2] iproute2: Add support for IPv6 VTI tunnels to ip6tunnel Jiri Pirko
2014-10-02 8:48 ` Steffen Klassert
2014-10-02 9:11 ` Jiri Pirko [this message]
2015-07-27 21:38 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141002091140.GA1865@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).