* [PATCH] drivers/net/dsa/Kconfig: Let NET_DSA_BCM_SF2 depend on HAS_IOMEM
@ 2014-10-02 14:14 Chen Gang
2014-10-02 16:44 ` Florian Fainelli
2014-10-03 22:52 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Chen Gang @ 2014-10-02 14:14 UTC (permalink / raw)
To: davem, f.fainelli, leitec, andrew
Cc: netdev@vger.kernel.org, Richard Weinberger,
linux-kernel@vger.kernel.org
NET_DSA_BCM_SF2 need HAS_IOMEM, so depend on it, the related error (with
allmodconfig under um):
CC [M] drivers/net/dsa/bcm_sf2.o
drivers/net/dsa/bcm_sf2.c: In function ‘bcm_sf2_sw_setup’:
drivers/net/dsa/bcm_sf2.c:487:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
iounmap(*base);
^
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/net/dsa/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig
index ea0697e..9234d80 100644
--- a/drivers/net/dsa/Kconfig
+++ b/drivers/net/dsa/Kconfig
@@ -47,6 +47,7 @@ config NET_DSA_MV88E6171
config NET_DSA_BCM_SF2
tristate "Broadcom Starfighter 2 Ethernet switch support"
+ depends on HAS_IOMEM
select NET_DSA
select NET_DSA_TAG_BRCM
select FIXED_PHY if NET_DSA_BCM_SF2=y
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drivers/net/dsa/Kconfig: Let NET_DSA_BCM_SF2 depend on HAS_IOMEM
2014-10-02 14:14 [PATCH] drivers/net/dsa/Kconfig: Let NET_DSA_BCM_SF2 depend on HAS_IOMEM Chen Gang
@ 2014-10-02 16:44 ` Florian Fainelli
2014-10-03 22:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2014-10-02 16:44 UTC (permalink / raw)
To: Chen Gang, davem, leitec, andrew
Cc: netdev@vger.kernel.org, Richard Weinberger,
linux-kernel@vger.kernel.org
On 10/02/2014 07:14 AM, Chen Gang wrote:
> NET_DSA_BCM_SF2 need HAS_IOMEM, so depend on it, the related error (with
> allmodconfig under um):
>
> CC [M] drivers/net/dsa/bcm_sf2.o
> drivers/net/dsa/bcm_sf2.c: In function ‘bcm_sf2_sw_setup’:
> drivers/net/dsa/bcm_sf2.c:487:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
> iounmap(*base);
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/net/dsa/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig
> index ea0697e..9234d80 100644
> --- a/drivers/net/dsa/Kconfig
> +++ b/drivers/net/dsa/Kconfig
> @@ -47,6 +47,7 @@ config NET_DSA_MV88E6171
>
> config NET_DSA_BCM_SF2
> tristate "Broadcom Starfighter 2 Ethernet switch support"
> + depends on HAS_IOMEM
> select NET_DSA
> select NET_DSA_TAG_BRCM
> select FIXED_PHY if NET_DSA_BCM_SF2=y
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/net/dsa/Kconfig: Let NET_DSA_BCM_SF2 depend on HAS_IOMEM
2014-10-02 14:14 [PATCH] drivers/net/dsa/Kconfig: Let NET_DSA_BCM_SF2 depend on HAS_IOMEM Chen Gang
2014-10-02 16:44 ` Florian Fainelli
@ 2014-10-03 22:52 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-10-03 22:52 UTC (permalink / raw)
To: gang.chen.5i5j; +Cc: f.fainelli, leitec, andrew, netdev, richard, linux-kernel
From: Chen Gang <gang.chen.5i5j@gmail.com>
Date: Thu, 02 Oct 2014 22:14:04 +0800
> NET_DSA_BCM_SF2 need HAS_IOMEM, so depend on it, the related error (with
> allmodconfig under um):
>
> CC [M] drivers/net/dsa/bcm_sf2.o
> drivers/net/dsa/bcm_sf2.c: In function ‘bcm_sf2_sw_setup’:
> drivers/net/dsa/bcm_sf2.c:487:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
> iounmap(*base);
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-03 22:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-02 14:14 [PATCH] drivers/net/dsa/Kconfig: Let NET_DSA_BCM_SF2 depend on HAS_IOMEM Chen Gang
2014-10-02 16:44 ` Florian Fainelli
2014-10-03 22:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).