* [PATCH] drivers/net/irda/Kconfig: Let SH_IRDA depend on HAS_IOMEM
@ 2014-10-02 14:32 Chen Gang
2014-10-03 22:52 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Chen Gang @ 2014-10-02 14:32 UTC (permalink / raw)
To: samuel
Cc: Richard Weinberger, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
SH_IRDA needs HAS_IOMEM, so depend on it. The related error(with
allmodconfig under um):
CC [M] drivers/net/irda/sh_irda.o
drivers/net/irda/sh_irda.c: In function ‘sh_irda_probe’:
drivers/net/irda/sh_irda.c:776:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
self->membase = ioremap_nocache(res->start, resource_size(res));
^
drivers/net/irda/sh_irda.c:776:16: warning: assignment makes pointer from integer without a cast [enabled by default]
self->membase = ioremap_nocache(res->start, resource_size(res));
^
drivers/net/irda/sh_irda.c:821:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
iounmap(self->membase);
^
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/net/irda/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/irda/Kconfig b/drivers/net/irda/Kconfig
index 8d101d6..a2c227b 100644
--- a/drivers/net/irda/Kconfig
+++ b/drivers/net/irda/Kconfig
@@ -397,7 +397,7 @@ config MCS_FIR
config SH_IRDA
tristate "SuperH IrDA driver"
depends on IRDA
- depends on ARCH_SHMOBILE || COMPILE_TEST
+ depends on (ARCH_SHMOBILE || COMPILE_TEST) && HAS_IOMEM
help
Say Y here if your want to enable SuperH IrDA devices.
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/net/irda/Kconfig: Let SH_IRDA depend on HAS_IOMEM
2014-10-02 14:32 [PATCH] drivers/net/irda/Kconfig: Let SH_IRDA depend on HAS_IOMEM Chen Gang
@ 2014-10-03 22:52 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-10-03 22:52 UTC (permalink / raw)
To: gang.chen.5i5j; +Cc: samuel, richard, netdev, linux-kernel
From: Chen Gang <gang.chen.5i5j@gmail.com>
Date: Thu, 02 Oct 2014 22:32:56 +0800
> SH_IRDA needs HAS_IOMEM, so depend on it. The related error(with
> allmodconfig under um):
>
> CC [M] drivers/net/irda/sh_irda.o
> drivers/net/irda/sh_irda.c: In function ‘sh_irda_probe’:
> drivers/net/irda/sh_irda.c:776:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
> self->membase = ioremap_nocache(res->start, resource_size(res));
> ^
> drivers/net/irda/sh_irda.c:776:16: warning: assignment makes pointer from integer without a cast [enabled by default]
> self->membase = ioremap_nocache(res->start, resource_size(res));
> ^
> drivers/net/irda/sh_irda.c:821:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
> iounmap(self->membase);
> ^
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-03 22:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-02 14:32 [PATCH] drivers/net/irda/Kconfig: Let SH_IRDA depend on HAS_IOMEM Chen Gang
2014-10-03 22:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).