From: David Miller <davem@davemloft.net>
To: john.fastabend@gmail.com
Cc: xiyou.wangcong@gmail.com, eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: sched: suspicious RCU usage in qdisc_watchdog
Date: Sat, 04 Oct 2014 20:46:15 -0400 (EDT) [thread overview]
Message-ID: <20141004.204615.153993151788265529.davem@davemloft.net> (raw)
In-Reply-To: <20141003054306.20821.48420.stgit@nitbit.x32>
From: John Fastabend <john.fastabend@gmail.com>
Date: Thu, 02 Oct 2014 22:43:09 -0700
> Suspicious RCU usage in qdisc_watchdog call needs to be done inside
> rcu_read_lock/rcu_read_unlock. And then Qdisc destroy operations
> need to ensure timer is cancelled before removing qdisc structure.
...
> Fixes: b26b0d1e8b1 ("net: qdisc: use rcu prefix and silence sparse warnings")
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Applied, thank you.
prev parent reply other threads:[~2014-10-05 0:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 5:43 [PATCH] net: sched: suspicious RCU usage in qdisc_watchdog John Fastabend
2014-10-03 22:22 ` Cong Wang
2014-10-05 0:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141004.204615.153993151788265529.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).