From: David Miller <davem@davemloft.net>
To: antoine.tenart@free-electrons.com
Cc: dan.carpenter@oracle.com, kou.ishizaki@toshiba.co.jp,
jens@de.ibm.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] net: spider_net: fix possible bitops errors
Date: Sun, 05 Oct 2014 21:15:52 -0400 (EDT) [thread overview]
Message-ID: <20141005.211552.452619735296906900.davem@davemloft.net> (raw)
In-Reply-To: <1412348517-20352-1-git-send-email-antoine.tenart@free-electrons.com>
From: Antoine Tenart <antoine.tenart@free-electrons.com>
Date: Fri, 3 Oct 2014 17:01:53 +0200
> Dan reported a possible signedness issue on the pxa168_eth driver. While
> having a look at it, I came across a similar problem in the spider_net
> driver.
>
> Here is one proposal to fix it. The first patch rework the
> spider_net_set_mac() function by removing the spider_net_get_mac_address()
> call and using memcpy() to set netdev->dev_addr (which is what's done in
> lots of Ethernet drivers) and the second one fix the actual signedness
> issue.
>
> If for any reason you really want to keep a call to
> spider_net_get_mac_address() because the memcpy() is somehow not good
> enough here, we can also come up with a solution involving a temporary
> unsigned char variable.
Series applied, thanks.
prev parent reply other threads:[~2014-10-06 1:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 15:01 [PATCH 0/2] net: spider_net: fix possible bitops errors Antoine Tenart
2014-10-03 15:01 ` [PATCH] net: pxa168_eth: avoid using signed char for bitops Antoine Tenart
2014-10-03 15:07 ` Antoine Tenart
2014-10-03 15:01 ` [PATCH 1/2] net: spider_net: do not read mac address again after setting it Antoine Tenart
2014-10-03 15:01 ` [PATCH 2/2] net: spider_net: avoid using signed char for bitops Antoine Tenart
2014-10-03 15:15 ` Arnd Bergmann
2014-10-03 15:17 ` Antoine Tenart
2014-10-06 1:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141005.211552.452619735296906900.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=antoine.tenart@free-electrons.com \
--cc=dan.carpenter@oracle.com \
--cc=jens@de.ibm.com \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).