Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: sched: avoid costly atomic operation in fq_dequeue()
Date: Mon, 06 Oct 2014 00:55:29 -0400 (EDT)	[thread overview]
Message-ID: <20141006.005529.1177842595653176576.davem@davemloft.net> (raw)
In-Reply-To: <1412442691.17245.40.camel@edumazet-glaptop2.roam.corp.google.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 04 Oct 2014 10:11:31 -0700

> From: Eric Dumazet <edumazet@google.com>
> 
> Standard qdisc API to setup a timer implies an atomic operation on every
> packet dequeue : qdisc_unthrottled()
> 
> It turns out this is not really needed for FQ, as FQ has no concept of
> global qdisc throttling, being a qdisc handling many different flows,
> some of them can be throttled, while others are not.
> 
> Fix is straightforward : add a 'bool throttle' to
> qdisc_watchdog_schedule_ns(), and remove calls to qdisc_unthrottled()
> in sch_fq.
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>

Applied, thanks Eric.

      reply	other threads:[~2014-10-06  4:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-04 17:11 [PATCH net-next] net: sched: avoid costly atomic operation in fq_dequeue() Eric Dumazet
2014-10-06  4:55 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141006.005529.1177842595653176576.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox