From: David Miller <davem@davemloft.net>
To: dborkman@redhat.com
Cc: edumazet@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv4: igmp: fix v3 general query drop monitor false positive
Date: Mon, 06 Oct 2014 17:15:24 -0400 (EDT) [thread overview]
Message-ID: <20141006.171524.1254375922559313117.davem@davemloft.net> (raw)
In-Reply-To: <1412522870-26335-1-git-send-email-dborkman@redhat.com>
From: Daniel Borkmann <dborkman@redhat.com>
Date: Sun, 5 Oct 2014 17:27:50 +0200
> In case we find a general query with non-zero number of sources, we
> are dropping the skb as it's malformed.
>
> RFC3376, section 4.1.8. Number of Sources (N):
>
> This number is zero in a General Query or a Group-Specific Query,
> and non-zero in a Group-and-Source-Specific Query.
>
> Therefore, reflect that by using kfree_skb() instead of consume_skb().
>
> Fixes: d679c5324d9a ("igmp: avoid drop_monitor false positives")
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Applied, thanks Daniel.
prev parent reply other threads:[~2014-10-06 21:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-05 15:27 [PATCH net-next] ipv4: igmp: fix v3 general query drop monitor false positive Daniel Borkmann
2014-10-05 17:12 ` Eric Dumazet
2014-10-06 21:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006.171524.1254375922559313117.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).