From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH V2 linux-next] net: fix rcu access on phonet_routes Date: Mon, 06 Oct 2014 18:16:51 -0400 (EDT) Message-ID: <20141006.181651.2058519626308257571.davem@davemloft.net> References: <1412619321-2212-1-git-send-email-fabf@skynet.be> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, edumazet@google.com, josh@joshtriplett.org, courmisch@gmail.com, netdev@vger.kernel.org To: fabf@skynet.be Return-path: In-Reply-To: <1412619321-2212-1-git-send-email-fabf@skynet.be> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Fabian Frederick Date: Mon, 6 Oct 2014 20:15:20 +0200 > -Add __rcu annotation on table to fix sparse warnings: > net/phonet/pn_dev.c:279:25: warning: incorrect type in assignment (different address spaces) > net/phonet/pn_dev.c:279:25: expected struct net_device * > net/phonet/pn_dev.c:279:25: got void [noderef] * > net/phonet/pn_dev.c:376:17: warning: incorrect type in assignment (different address spaces) > net/phonet/pn_dev.c:376:17: expected struct net_device *volatile > net/phonet/pn_dev.c:376:17: got struct net_device [noderef] * > net/phonet/pn_dev.c:392:17: warning: incorrect type in assignment (different address spaces) > net/phonet/pn_dev.c:392:17: expected struct net_device * > net/phonet/pn_dev.c:392:17: got void [noderef] * > > -Access table with rcu_access_pointer (fixes the following sparse errors): > net/phonet/pn_dev.c:278:25: error: incompatible types in comparison expression (different address spaces) > net/phonet/pn_dev.c:391:17: error: incompatible types in comparison expression (different address spaces) > > Suggested-by: Eric Dumazet > Signed-off-by: Fabian Frederick > --- > V2: use rcu_access_pointer instead of rcu_dereference out of rcu_read_lock context > (suggested by Eric Dumazet). Applied, thank you.