From: josh@joshtriplett.org
To: Joe Perches <joe@perches.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
john.fastabend@gmail.com
Subject: Re: [PATCH net-next] net: core: Quiet W=1 warnings for unused vars and static functions
Date: Mon, 6 Oct 2014 15:27:56 -0700 [thread overview]
Message-ID: <20141006222756.GA1497@cloud> (raw)
In-Reply-To: <1412633064.2916.46.camel@joe-AO725>
On Mon, Oct 06, 2014 at 03:04:24PM -0700, Joe Perches wrote:
> On Mon, 2014-10-06 at 17:56 -0400, David Miller wrote:
> > From: Joe Perches <joe@perches.com>
> > Date: Mon, 06 Oct 2014 14:51:38 -0700
> >
> > > Reduce noise when compiling W=1.
> []
> > BTW, this patch reminds me that if people think there are
> > subdirectories where we can turn on things like -Werror in the
> > networking I would be very happy to apply such patches.
> []
> > Things like net/core/ for example should be doable for sure.
>
> I don't have any significant opposition to -Werror, but
> I think there are real arguments _against_ using -Werror.
>
> I think the primary one is new compiler versions have a
> tendency to add new warnings for various things that can
> unnecessarily and unpredictably break the build.
-Werror is a bad idea, even on a per-directory basis. However,
-Werror=specific-warning is a great idea. We should add that for
high-value warnings that have been entirely eliminated in a directory.
- Josh Triplett
next prev parent reply other threads:[~2014-10-06 22:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 21:51 [PATCH net-next] net: core: Quiet W=1 warnings for unused vars and static functions Joe Perches
2014-10-06 21:56 ` David Miller
2014-10-06 22:04 ` Joe Perches
2014-10-06 22:19 ` David Miller
2014-10-06 22:27 ` josh [this message]
2014-10-06 22:02 ` Eric Dumazet
2014-10-06 22:12 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141006222756.GA1497@cloud \
--to=josh@joshtriplett.org \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).