From: David Miller <davem@davemloft.net>
To: ivecera@redhat.com
Cc: netdev@vger.kernel.org, rasesh.mody@qlogic.com
Subject: Re: [PATCH net] bna: allow transmit tagged frames
Date: Tue, 07 Oct 2014 00:02:00 -0400 (EDT) [thread overview]
Message-ID: <20141007.000200.1161558430661614993.davem@davemloft.net> (raw)
In-Reply-To: <1412614957-18549-1-git-send-email-ivecera@redhat.com>
From: Ivan Vecera <ivecera@redhat.com>
Date: Mon, 6 Oct 2014 19:02:37 +0200
> When Tx VLAN offloading is disabled frames with size ~ MTU are not
> transmitted as the driver does not account 4 bytes of VLAN header added
> by stack. It should use VLAN_ETH_HLEN instead of ETH_HLEN.
>
> The second problem is with newer BNA chips (BNA 1860). These chips filter
> out any VLAN tagged frames in Tx path. This is a problem when Tx VLAN
> offloading is disabled and frames are tagged by stack. Older chips like
> 1010/1020 are not affected as they probably don't do such filtering.
>
> Cc: Rasesh Mody <rasesh.mody@qlogic.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2014-10-07 4:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 17:02 [PATCH net] bna: allow transmit tagged frames Ivan Vecera
2014-10-07 4:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007.000200.1161558430661614993.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ivecera@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rasesh.mody@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).