netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next V1 00/14] net/mlx4_en: Optimizations to TX flow
@ 2014-10-06  6:15 Amir Vadai
  2014-10-06  6:15 ` [PATCH net-next V1 01/14] net/mlx4_en: Code cleanups in tx path Amir Vadai
                   ` (14 more replies)
  0 siblings, 15 replies; 21+ messages in thread
From: Amir Vadai @ 2014-10-06  6:15 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet
  Cc: netdev, Yevgeny Petrilin, Or Gerlitz, Ido Shamay, Amir Vadai

Hi,

This patchset contains optimizations to TX flow in mlx4_en driver. It also introduce
setting/getting tx copybreak, to enable controlling inline threshold dynamically.

TX flow optimizations was authored and posted to the mailing list by Eric
Dumazet [1] as a single patch. I splitted this patch to smaller patches,
Reviewed it and tested.
Changed from original patch:
- s/iowrite32be/iowrite32/, since ring->doorbell_qpn is stored as be32

The tx copybreak patch was also suggested by Eric Dumazet, and was edited and
reviewed by me. User space patch will be sent after kernel code is ready.

I am sending this patchset now since the merge window is near and don't want to
miss it.

More work need to do:
- Disable BF when xmit_more is in use
- Make TSO use xmit_more too. Maybe by splitting small TSO packets in the
  driver itself, to avoid extra cpu/memory costs of GSO before the driver
- Fix mlx4_en_xmit buggy handling of queue full in the middle of a burst
  partially posted to send queue using xmit_more

Eric, I edited the patches to have you as the Author and the first
signed-off-by. I hope it is ok with you (I wasn't sure if it is ok to sign by
you), anyway all the credit to those changes should go to you.

Patchset was tested and applied over commit 1e203c1 "(net: sched:
suspicious RCU usage in qdisc_watchdog")

[1] - https://patchwork.ozlabs.org/patch/394256/

Changes from V0:
- Patch 14/14 ("Use the new tx_copybreak to set inline threshold"):
  - Use same coding convention as currently is in en_ethtool.c
- Patch 1/14 ("Code cleanups in tx path") and Patch 9/14 ("Use local var in
  tx flow for skb_shinfo(skb)"):
  - local var shinfo was used by mistake in Patch 1/14 while declared at 9/14.
    Fixed it for the sake of future bisections

Thanks,
Amir

Eric Dumazet (14):
  net/mlx4_en: Code cleanups in tx path
  net/mlx4_en: Align tx path structures to cache lines
  net/mlx4_en: Avoid calling bswap in tx fast path
  net/mlx4_en: tx_info allocated with kmalloc() instead of vmalloc()
  net/mlx4_en: Avoid a cache line miss in TX completion for single frag
    skb's
  net/mlx4_en: Use prefetch in tx path
  net/mlx4_en: Avoid false sharing in mlx4_en_en_process_tx_cq()
  net/mlx4_en: mlx4_en_xmit() reads ring->cons once, and ahead of time
    to avoid stalls
  net/mlx4_en: Use local var in tx flow for skb_shinfo(skb)
  net/mlx4_en: Use local var for skb_headlen(skb)
  net/mlx4_en: tx_info->ts_requested was not cleared
  net/mlx4_en: Enable the compiler to make is_inline() inlined
  ethtool: Ethtool parameter to dynamically change tx_copybreak
  net/mlx4_en: Use the new tx_copybreak to set inline threshold

 drivers/net/ethernet/mellanox/mlx4/en_ethtool.c |  44 ++++
 drivers/net/ethernet/mellanox/mlx4/en_tx.c      | 330 ++++++++++++++----------
 drivers/net/ethernet/mellanox/mlx4/mlx4_en.h    |  90 ++++---
 include/linux/mlx4/device.h                     |   2 +-
 include/uapi/linux/ethtool.h                    |   1 +
 net/core/ethtool.c                              |   1 +
 6 files changed, 290 insertions(+), 178 deletions(-)

-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 21+ messages in thread
end of thread, other threads:[~2014-10-07 17:21 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-06  6:15 [PATCH net-next V1 00/14] net/mlx4_en: Optimizations to TX flow Amir Vadai
2014-10-06  6:15 ` [PATCH net-next V1 01/14] net/mlx4_en: Code cleanups in tx path Amir Vadai
2014-10-06  6:15 ` [PATCH net-next V1 02/14] net/mlx4_en: Align tx path structures to cache lines Amir Vadai
2014-10-06  6:15 ` [PATCH net-next V1 03/14] net/mlx4_en: Avoid calling bswap in tx fast path Amir Vadai
2014-10-06  6:15 ` [PATCH net-next V1 04/14] net/mlx4_en: tx_info allocated with kmalloc() instead of vmalloc() Amir Vadai
2014-10-06  6:15 ` [PATCH net-next V1 05/14] net/mlx4_en: Avoid a cache line miss in TX completion for single frag skb's Amir Vadai
2014-10-06  6:15 ` [PATCH net-next V1 06/14] net/mlx4_en: Use prefetch in tx path Amir Vadai
2014-10-06  6:15 ` [PATCH net-next V1 07/14] net/mlx4_en: Avoid false sharing in mlx4_en_en_process_tx_cq() Amir Vadai
2014-10-06  6:15 ` [PATCH net-next V1 08/14] net/mlx4_en: mlx4_en_xmit() reads ring->cons once, and ahead of time to avoid stalls Amir Vadai
2014-10-06  6:15 ` [PATCH net-next V1 09/14] net/mlx4_en: Use local var in tx flow for skb_shinfo(skb) Amir Vadai
2014-10-06  6:15 ` [PATCH net-next V1 10/14] net/mlx4_en: Use local var for skb_headlen(skb) Amir Vadai
2014-10-06  6:16 ` [PATCH net-next V1 11/14] net/mlx4_en: tx_info->ts_requested was not cleared Amir Vadai
2014-10-06  6:16 ` [PATCH net-next V1 12/14] net/mlx4_en: Enable the compiler to make is_inline() inlined Amir Vadai
2014-10-06  6:16 ` [PATCH net-next V1 13/14] ethtool: Ethtool parameter to dynamically change tx_copybreak Amir Vadai
2014-10-06  6:16 ` [PATCH net-next V1 14/14] net/mlx4_en: Use the new tx_copybreak to set inline threshold Amir Vadai
2014-10-06 12:51 ` [PATCH net-next V1 00/14] net/mlx4_en: Optimizations to TX flow Eric Dumazet
2014-10-06 12:54   ` Amir Vadai
2014-10-06 16:30   ` [PATCH net-next] net/mlx4_en: remove NETDEV_TX_BUSY Eric Dumazet
2014-10-07  8:30     ` Amir Vadai
2014-10-07 12:38       ` Eric Dumazet
2014-10-07 17:21       ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).