From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, ja@ssi.bg
Subject: Re: [PATCH v2 net-next] net: better IFF_XMIT_DST_RELEASE support
Date: Tue, 07 Oct 2014 13:22:44 -0400 (EDT) [thread overview]
Message-ID: <20141007.132244.460509534988004588.davem@davemloft.net> (raw)
In-Reply-To: <1412633126.11091.89.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 06 Oct 2014 15:05:26 -0700
> We have a loop over team/bonding members, where we do :
>
> dst_release_flag &= slave->dev->priv_flags;
>
> So at the end of the loop, we check if any one of the member had one of
> the bit cleared.
>
> if dst_release_flags has both bits set, then we are set and we allow the
> IFF_XMIT_DST_RELEASE being set on the master.
Oh I see, I mis-read the patch thinking dst_release_flags was a new variable
when in fact it's an existing one.
Patch applied, thanks Eric.
prev parent reply other threads:[~2014-10-07 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 1:38 [PATCH v2 net-next] net: better IFF_XMIT_DST_RELEASE support Eric Dumazet
2014-10-06 21:50 ` David Miller
2014-10-06 22:05 ` Eric Dumazet
2014-10-07 17:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007.132244.460509534988004588.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).