From: Thomas Graf <tgraf@suug.ch>
To: David Miller <davem@davemloft.net>
Cc: alexei.starovoitov@gmail.com, therbert@google.com,
jesse@nicira.com, gerlitz.or@gmail.com,
alexander.h.duyck@intel.com, john.r.fastabend@intel.com,
jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
pshelar@nicira.com, azhou@nicira.com
Subject: Re: [PATCH] net: Add ndo_gso_check
Date: Tue, 7 Oct 2014 22:41:32 +0100 [thread overview]
Message-ID: <20141007214132.GA3181@casper.infradead.org> (raw)
In-Reply-To: <20141007.164802.624713385845633192.davem@davemloft.net>
On 10/07/14 at 04:48pm, David Miller wrote:
> So we have to write new software in _EVERY_ driver to accomodate this.
>
> That makes zero sense either, and it is unneeded complexity in the
> hardware.
>
> COMPLETE works everywhere, on everything, with no driver changes, and
> is so much harder to get wrong.
>
> Every protocol specific feature has major downsides whether you choose
> to see them or not.
It's probably not overly bold to state that the behaviour behind
CHECKSUM_UNNECESSARY was not created for technical reasons in the
first place.
I enourage NICs to have protocol awareness in the absence of full
programmability but I agree with Dave that there is little to no
reason to expose anything but the full packet checksum to the CPU.
next prev parent reply other threads:[~2014-10-07 21:41 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 16:50 [PATCH] net: Add ndo_gso_check Alexei Starovoitov
2014-10-07 17:05 ` David Miller
2014-10-07 17:18 ` Alexei Starovoitov
2014-10-07 18:47 ` David Miller
2014-10-07 20:28 ` Alexei Starovoitov
2014-10-07 20:32 ` David Miller
2014-10-07 20:43 ` Alexei Starovoitov
2014-10-07 20:48 ` David Miller
2014-10-07 21:41 ` Thomas Graf [this message]
2014-10-07 17:23 ` Eric Dumazet
2014-10-07 18:15 ` Alexei Starovoitov
2014-10-07 18:50 ` Eric Dumazet
2014-10-07 18:51 ` David Miller
2014-10-07 19:10 ` Tom Herbert
-- strict thread matches above, loose matches on Subject: below --
2014-10-07 22:05 Alexei Starovoitov
2014-10-07 23:43 ` Tom Herbert
2014-09-29 3:50 Tom Herbert
2014-09-29 19:59 ` Or Gerlitz
2014-09-29 20:12 ` David Miller
2014-09-29 20:53 ` Tom Herbert
2014-09-29 21:10 ` Or Gerlitz
2014-09-29 21:38 ` Tom Herbert
2014-09-30 14:30 ` Or Gerlitz
2014-09-30 15:34 ` Tom Herbert
2014-09-30 21:37 ` Stephen Hemminger
2014-09-30 22:11 ` Eric Dumazet
2014-10-01 0:05 ` Tom Herbert
2014-10-01 0:18 ` Eric Dumazet
2014-10-01 6:12 ` Eric Dumazet
2014-10-01 20:58 ` Or Gerlitz
2014-10-01 21:12 ` Jesse Gross
2014-10-01 23:06 ` Tom Herbert
2014-10-05 14:04 ` Or Gerlitz
2014-10-05 18:49 ` Tom Herbert
2014-10-05 19:13 ` Or Gerlitz
2014-10-06 17:59 ` Tom Herbert
2014-10-06 20:22 ` Or Gerlitz
2014-10-06 21:28 ` Tom Herbert
2014-10-07 11:07 ` Or Gerlitz
2015-01-15 18:18 ` Or Gerlitz
2014-10-06 22:33 ` Jesse Gross
2014-10-07 0:17 ` Tom Herbert
2014-10-09 0:30 ` Jesse Gross
2014-10-09 1:46 ` Tom Herbert
2014-10-06 21:51 ` Jesse Gross
2014-09-29 20:13 ` Jesse Gross
2014-09-29 20:47 ` Tom Herbert
2014-09-30 0:33 ` Jesse Gross
2014-09-30 1:59 ` Tom Herbert
2014-10-07 18:13 ` Tom Herbert
2014-10-07 20:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141007214132.GA3181@casper.infradead.org \
--to=tgraf@suug.ch \
--cc=alexander.h.duyck@intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=azhou@nicira.com \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse@nicira.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).