netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: "luwei.zhou@freescale.com" <luwei.zhou@freescale.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
	"bhutchings@solarflare.com" <bhutchings@solarflare.com>,
	"Fabio.Estevam@freescale.com" <Fabio.Estevam@freescale.com>,
	"fugang.duan@freescale.com" <fugang.duan@freescale.com>,
	"Frank.Li@freescale.com" <Frank.Li@freescale.com>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: Re: [PATCH v1 4/4] ARM: Documentation: Update fec dts binding doc
Date: Wed, 8 Oct 2014 10:06:03 +0200	[thread overview]
Message-ID: <20141008080603.GA4648@netboy> (raw)
In-Reply-To: <39bcecf4ec1a4862bc7316dc845a535c@BY2PR03MB441.namprd03.prod.outlook.com>

On Wed, Oct 08, 2014 at 03:15:08AM +0000, luwei.zhou@freescale.com wrote:
> On Wed, Oct 1, 2014 at 11:59:00AM, Richard Cochran wrote:
> > -----Original Message-----
> > From: Richard Cochran [mailto:richardcochran@gmail.com]
> > Sent: Wednesday, October 01, 2014 11:59 AM
> > To: Zhou Luwei-B45643
> > Cc: davem@davemloft.net; netdev@vger.kernel.org; shawn.guo@linaro.org;
> > bhutchings@solarflare.com; Estevam Fabio-R49496; Duan Fugang-B38611; Li
> > Frank-B20596; stephen@networkplumber.org
> > Subject: Re: [PATCH v1 4/4] ARM: Documentation: Update fec dts binding
> > doc
> > 
> > On Thu, Sep 25, 2014 at 04:43:50PM +0200, Richard Cochran wrote:
> > > On Thu, Sep 25, 2014 at 04:10:21PM +0800, Luwei Zhou wrote:
> > > > This patch update fec devicetree binding doc that add Optional
> > > > properties "pps-channel".
> > >
> > > Again, use the PTP pin interface. We don't need a random new FEC DT
> > > property for this.
> > 
> > BTW, if the "channel" only means an internal timer resource, please find
> > a proper way to claim that resource. Do not add another random DT
> > property. We have enough of those already.
> > 
> > Thanks,
> > Richard
> 
> Okay. I will use the PTP pin interface to let user set the channel index as V2 patch does. Sorry for the
> late reply caused by vocation.

Do not use the PTP pin control for an internal PPS event. Instead,
just claim the timer as some kind of internal resource. It looks like
timers are already part of DT, so why not use those?

Thanks,
Richard

  reply	other threads:[~2014-10-08  8:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25  8:10 [PATCH v1 0/4] Enable FEC pps ouput Luwei Zhou
2014-09-25  8:10 ` [PATCH v1 1/4] net: fec: ptp: Use the 31-bit ptp timer Luwei Zhou
2014-09-25  8:10 ` [PATCH v1 2/4] net: fec: ptp: Use hardware algorithm to adjust PTP counter Luwei Zhou
2014-09-25 13:29   ` Frank.Li
2014-09-26  5:12     ` luwei.zhou
2014-09-26 14:31       ` Frank.Li
2014-09-25 14:29   ` Richard Cochran
2014-09-26  5:53     ` luwei.zhou
2014-09-26  8:22       ` Richard Cochran
2014-09-25  8:10 ` [PATCH v1 3/4] net: fec: ptp: Enalbe PPS ouput based on ptp clock Luwei Zhou
2014-09-25 14:41   ` Richard Cochran
2014-09-26  6:35     ` luwei.zhou
2014-09-25  8:10 ` [PATCH v1 4/4] ARM: Documentation: Update fec dts binding doc Luwei Zhou
2014-09-25 14:43   ` Richard Cochran
2014-10-01  3:59     ` Richard Cochran
2014-10-08  3:15       ` luwei.zhou
2014-10-08  8:06         ` Richard Cochran [this message]
2014-10-08  8:36           ` luwei.zhou
2014-10-08 10:13             ` Richard Cochran
2014-10-09  2:19               ` luwei.zhou
2014-10-09  6:52                 ` Richard Cochran
2014-10-09  7:11                   ` luwei.zhou
2014-10-03  8:23 ` [PATCH v1 0/4] Enable FEC pps ouput Richard Cochran
2014-10-08  3:30   ` luwei.zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141008080603.GA4648@netboy \
    --to=richardcochran@gmail.com \
    --cc=Fabio.Estevam@freescale.com \
    --cc=Frank.Li@freescale.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=fugang.duan@freescale.com \
    --cc=luwei.zhou@freescale.com \
    --cc=netdev@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).