From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: hariprasad@chelsio.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2 -next] cxgb4: clean up a type issue
Date: Wed, 8 Oct 2014 13:18:19 +0300 [thread overview]
Message-ID: <20141008101819.GB26918@mwanda> (raw)
In-Reply-To: <20141003.154629.555967384624529643.davem@davemloft.net>
On Fri, Oct 03, 2014 at 03:46:29PM -0700, David Miller wrote:
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Thu, 2 Oct 2014 14:22:19 +0300
>
> > The tx_desc struct hold 8 __be64 values. The original code took a
> > tx_desc pointer then casted it to an int pointer and then casted it to a
> > u64 pointer. It was confusing and triggered some static checker
> > warnings.
> >
> > I have changed the cxgb_pio_copy() to only take tx_desc pointers. This
> > isn't really a loss of flexibility because anything else was buggy to
> > begin with.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Please address the feedback you've received, resubmit this series, and actually
> number this second change "2/2" instead of "1/2" :-)
>
Yes. Sorry for the delay. I'll send that this afternoon.
regards,
dan carpenter
next prev parent reply other threads:[~2014-10-08 10:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 11:22 [patch 1/2 -next] cxgb4: clean up a type issue Dan Carpenter
2014-10-02 11:31 ` David Laight
2014-10-03 22:46 ` David Miller
2014-10-08 10:18 ` Dan Carpenter [this message]
2014-10-08 13:43 ` [patch 1/2 v2 -next] cxgb4: potential shift wrapping bug Dan Carpenter
2014-10-08 20:08 ` David Miller
2014-10-08 13:44 ` [patch 2/2 v2 -next] cxgb4: clean up a type issue Dan Carpenter
2014-10-08 20:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141008101819.GB26918@mwanda \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=hariprasad@chelsio.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).