From: David Miller <davem@davemloft.net>
To: akshaysarode21@gmail.com
Cc: john.stultz@linaro.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Checkpatch: coding style errors in Nvidia ethernet driver
Date: Fri, 10 Oct 2014 14:25:46 -0400 (EDT) [thread overview]
Message-ID: <20141010.142546.2200998192474741214.davem@davemloft.net> (raw)
In-Reply-To: <1412928102-1696-1-git-send-email-akshaysarode21@gmail.com>
From: Akshay Sarode <akshaysarode21@gmail.com>
Date: Fri, 10 Oct 2014 13:31:42 +0530
> ERROR: "foo* bar" should be "foo *bar"
> ERROR: do not initialise statics to 0 or NULL
> CHECK: spinlock_t definition without comment
> Signed-off-by: Akshay Sarode <akshaysarode21@gmail.com>
The Subject "Subsystem: " prefix is meant to refer to what area of
the kernel you are changing.
You aren't making changes to "Checkpatch: " so that isn't an
appropriate prefix. Someone scanning the commit header lines
won't be able to tell what part of the kernel your change is
touching.
In this case you should use "nvidia: " as your subsystem
prefix.
prev parent reply other threads:[~2014-10-10 18:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 8:01 [PATCH 1/1] Checkpatch: coding style errors in Nvidia ethernet driver Akshay Sarode
2014-10-10 15:03 ` Joe Perches
2014-10-10 16:45 ` Akshay Sarode
2014-10-10 17:04 ` Joe Perches
2014-10-10 18:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141010.142546.2200998192474741214.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akshaysarode21@gmail.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox