From: David Miller <davem@davemloft.net>
To: jbaron@akamai.com
Cc: eric.dumazet@gmail.com, stephen@networkplumber.org,
vyasevich@gmail.com, kaber@trash.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] macvlan: optimize receive path
Date: Fri, 10 Oct 2014 15:10:24 -0400 (EDT) [thread overview]
Message-ID: <20141010.151024.832041296782975325.davem@davemloft.net> (raw)
In-Reply-To: <cover.1412908929.git.jbaron@akamai.com>
From: Jason Baron <jbaron@akamai.com>
Date: Fri, 10 Oct 2014 03:13:24 +0000 (GMT)
> So after porting this optimization to net-next, I found that the netperf
> results of TCP_RR regress right at the maximum peak of transactions/sec. That
> is as I increase the number of threads via the first argument to super_netperf,
> the number of transactions/sec keep increasing, peak, and then start
> decreasing. It is right at the peak, that I see a small regression with this
> patch (see results in patch 2/2).
>
> Without the patch, the ksoftirqd threads are the top cpu consumers threads on
> the system, since the extra 'netif_rx()', is queuing more softirq work, whereas
> with the patch, the ksoftirqd threads are below all of the 'netserver' threads
> in terms of their cpu usage. So there appears to be some interaction between how
> softirqs are serviced at the peak here and this patch. I think the test results
> are still supportive of this approach, but I wanted to be clear on my findings.
I think this is definitely the right thing to do, applied, thanks!
prev parent reply other threads:[~2014-10-10 19:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 3:13 [PATCH net-next 0/2] macvlan: optimize receive path Jason Baron
2014-10-10 3:13 ` [PATCH net-next 1/2] macvlan: pass 'bool' type to macvlan_count_rx() Jason Baron
2014-10-10 3:13 ` [PATCH net-next 2/2] macvlan: optimize the receive path Jason Baron
2014-10-10 19:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141010.151024.832041296782975325.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jbaron@akamai.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).