From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: nf_reject_ipv4: module license 'unspecified' taints kernel Date: Fri, 10 Oct 2014 11:56:16 +0200 Message-ID: <20141010095520.GA3126@salvia> References: <20141010091904.GD1981@darkstar.nay.redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="mojUlQ0s9EVzWg2t" Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org To: Dave Young Return-path: Content-Disposition: inline In-Reply-To: <20141010091904.GD1981@darkstar.nay.redhat.com> Sender: netfilter-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org --mojUlQ0s9EVzWg2t Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 10, 2014 at 05:19:04PM +0800, Dave Young wrote: > Hi, > > With today's linus tree, I got below kmsg: > [ 23.545204] nf_reject_ipv4: module license 'unspecified' taints kernel. > > It could be caused by below commit: > > commit c8d7b98bec43faaa6583c3135030be5eb4693acb > Author: Pablo Neira Ayuso > Date: Fri Sep 26 14:35:15 2014 +0200 > > netfilter: move nf_send_resetX() code to nf_reject_ipvX modules > > Move nf_send_reset() and nf_send_reset6() to nf_reject_ipv4 and > nf_reject_ipv6 respectively. This code is shared by x_tables and > nf_tables. > > Signed-off-by: Pablo Neira Ayuso Patch attached, thanks for reporting. P.S: Please, Cc netfilter-devel@vger.kernel.org in future reports, so we make sure things don't get lost. --mojUlQ0s9EVzWg2t Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-netfilter-missing-module-license-in-the-nf_reject_ip.patch" >>From d4358bcf64ba7a64d4de4e1dc5533c4c8f88ea82 Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Fri, 10 Oct 2014 11:25:20 +0200 Subject: [PATCH] netfilter: missing module license in the nf_reject_ipvX modules [ 23.545204] nf_reject_ipv4: module license 'unspecified' taints kernel. Reported-by: Dave Young Signed-off-by: Pablo Neira Ayuso --- net/ipv4/netfilter/nf_reject_ipv4.c | 3 +++ net/ipv6/netfilter/nf_reject_ipv6.c | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/net/ipv4/netfilter/nf_reject_ipv4.c b/net/ipv4/netfilter/nf_reject_ipv4.c index b023b4e..92b303d 100644 --- a/net/ipv4/netfilter/nf_reject_ipv4.c +++ b/net/ipv4/netfilter/nf_reject_ipv4.c @@ -6,6 +6,7 @@ * published by the Free Software Foundation. */ +#include #include #include #include @@ -125,3 +126,5 @@ void nf_send_reset(struct sk_buff *oldskb, int hook) kfree_skb(nskb); } EXPORT_SYMBOL_GPL(nf_send_reset); + +MODULE_LICENSE("GPL"); diff --git a/net/ipv6/netfilter/nf_reject_ipv6.c b/net/ipv6/netfilter/nf_reject_ipv6.c index 5f5f043..20d9def 100644 --- a/net/ipv6/netfilter/nf_reject_ipv6.c +++ b/net/ipv6/netfilter/nf_reject_ipv6.c @@ -5,6 +5,8 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ + +#include #include #include #include @@ -161,3 +163,5 @@ void nf_send_reset6(struct net *net, struct sk_buff *oldskb, int hook) ip6_local_out(nskb); } EXPORT_SYMBOL_GPL(nf_send_reset6); + +MODULE_LICENSE("GPL"); -- 1.7.10.4 --mojUlQ0s9EVzWg2t--