From: Stephen Hemminger <stephen@networkplumber.org>
To: Andy Grover <andy.grover@oracle.com>
Cc: netdev@vger.kernel.org
Subject: Fw: [Bug 86081] New: Can't free the return value of sock_kmalloc() when the value is NULL
Date: Sun, 12 Oct 2014 17:07:56 +0200 [thread overview]
Message-ID: <20141012170756.19d1d12e@uryu.home.lan> (raw)
Begin forwarded message:
Date: Sun, 12 Oct 2014 01:26:47 -0700
From: "bugzilla-daemon@bugzilla.kernel.org" <bugzilla-daemon@bugzilla.kernel.org>
To: "stephen@networkplumber.org" <stephen@networkplumber.org>
Subject: [Bug 86081] New: Can't free the return value of sock_kmalloc() when the value is NULL
https://bugzilla.kernel.org/show_bug.cgi?id=86081
Bug ID: 86081
Summary: Can't free the return value of sock_kmalloc() when the
value is NULL
Product: Networking
Version: 2.5
Kernel Version: 3.14
Hardware: All
OS: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Other
Assignee: shemminger@linux-foundation.org
Reporter: rucsoftsec@gmail.com
Regression: No
in function rds_cmsg_rdma_args() at net/rds/rdma.c:L546, the variable
"iovstack" is an array and the pointer variable *iovs is equal to iovstack (at
Line 554). As the the return value of sock_kmalloc() (called at line 578),when
"iovs" is NULL, function sock_kfree_s() will be called(at line 697) and
function sock_kfree_s() will free "iovs".
The related code snippets in function rds_cmsg_rdma_args() are as followings.
rds_cmsg_rdma_args() at net/rds/rdma.c:L546
546 int rds_cmsg_rdma_args(struct rds_sock *rs, struct rds_message *rm,
547 struct cmsghdr *cmsg)
548 {
549 struct rds_rdma_args *args;
550 struct rm_rdma_op *op = &rm->rdma;
551 int nr_pages;
552 unsigned int nr_bytes;
553 struct page **pages = NULL;
554 struct rds_iovec iovstack[UIO_FASTIOV], *iovs = iovstack;
...
576 iov_size = args->nr_local * sizeof(struct rds_iovec);
577 if (args->nr_local > UIO_FASTIOV) {
578 iovs = sock_kmalloc(rds_rs_to_sk(rs), iov_size,
GFP_KERNEL);
579 if (!iovs) {
580 ret = -ENOMEM;
581 goto out;
582 }
583 }
...
695 out:
696 if (iovs != iovstack)
697 sock_kfree_s(rds_rs_to_sk(rs), iovs, iov_size);
698 kfree(pages);
699 if (ret)
700 rds_rdma_free_op(op);
701 else
702 rds_stats_inc(s_send_rdma);
703
704 return ret;
705 }
Thak you!
RUC_Soft_Sec, supported by China.X.Orion
--
You are receiving this mail because:
You are the assignee for the bug.
next reply other threads:[~2014-10-12 15:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 15:07 Stephen Hemminger [this message]
2014-10-13 20:58 ` Fw: [Bug 86081] New: Can't free the return value of sock_kmalloc() when the value is NULL Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141012170756.19d1d12e@uryu.home.lan \
--to=stephen@networkplumber.org \
--cc=andy.grover@oracle.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).